squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Merge pull request #2983 from mikerite/fix_warnings_20180730

Browse source 
Fix compiler warnings
This commit is contained in:
Philipp Hansch 2018-08-01 06:18:18 +01:00 committed by GitHub
commit 4dbc62baf8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
clippy_lints/src/consts.rs
View file

@ -241,7 +241,7 @@ impl<'c, 'cc> ConstEvalLateContext<'c, 'cc> {
match *o {
Bool(b) => Some(Bool(!b)),
Int(value) => {
let mut value = !value;
let value = !value;
match ty.sty {
ty::TyInt(ity) => Some(Int(unsext(self.tcx, value as i128, ity))),
ty::TyUint(ity) => Some(Int(clip(self.tcx, value, ity))),

4
clippy_lints/src/lib.rs
View file

@ -366,9 +366,11 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>) {
reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
reg.register_late_lint_pass(box explicit_write::Pass);
reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
let target = &reg.sess.target;
reg.register_late_lint_pass(box trivially_copy_pass_by_ref::TriviallyCopyPassByRef::new(
conf.trivial_copy_size_limit,
&reg.sess.target,
target,
));
reg.register_early_lint_pass(box literal_representation::LiteralDigitGrouping);
reg.register_early_lint_pass(box literal_representation::LiteralRepresentation::new(

6
clippy_lints/src/utils/hir_utils.rs
View file

@ -448,7 +448,8 @@ impl<'a, 'tcx: 'a> SpanlessHash<'a, 'tcx> {
CaptureClause::CaptureByValue => 0,
CaptureClause::CaptureByRef => 1,
}.hash(&mut self.s);
self.hash_expr(&self.cx.tcx.hir.body(eid).value);
let value = &self.cx.tcx.hir.body(eid).value;
self.hash_expr(value);
},
ExprKind::Field(ref e, ref f) => {
let c: fn(_, _) -> _ = ExprKind::Field;
@ -515,7 +516,8 @@ impl<'a, 'tcx: 'a> SpanlessHash<'a, 'tcx> {
self.hash_expr(e);
let full_table = self.tables;
self.tables = self.cx.tcx.body_tables(l_id.body);
self.hash_expr(&self.cx.tcx.hir.body(l_id.body).value);
let value = &self.cx.tcx.hir.body(l_id.body).value;
self.hash_expr(value);
self.tables = full_table;
},
ExprKind::Ret(ref e) => {