diff --git a/src/librustc/metadata/loader.rs b/src/librustc/metadata/loader.rs index d30df131d4d..6d94f075290 100644 --- a/src/librustc/metadata/loader.rs +++ b/src/librustc/metadata/loader.rs @@ -357,9 +357,8 @@ impl<'a> Context<'a> { // must be loaded via -L plus some filtering. if self.hash.is_none() { self.should_match_name = false; - match self.find_commandline_library() { - Some(l) => return Some(l), - None => {} + if let Some(s) = self.sess.opts.externs.get(self.crate_name) { + return self.find_commandline_library(s); } self.should_match_name = true; } @@ -596,12 +595,7 @@ impl<'a> Context<'a> { (t.options.dll_prefix.clone(), t.options.dll_suffix.clone()) } - fn find_commandline_library(&mut self) -> Option { - let locs = match self.sess.opts.externs.get(self.crate_name) { - Some(s) => s, - None => return None, - }; - + fn find_commandline_library(&mut self, locs: &[String]) -> Option { // First, filter out all libraries that look suspicious. We only accept // files which actually exist that have the correct naming scheme for // rlibs/dylibs. diff --git a/src/test/run-make/use-extern-for-plugins/Makefile b/src/test/run-make/use-extern-for-plugins/Makefile new file mode 100644 index 00000000000..84032b45159 --- /dev/null +++ b/src/test/run-make/use-extern-for-plugins/Makefile @@ -0,0 +1,13 @@ +-include ../tools.mk + +HOST := $(shell $(RUSTC) -vV | grep 'host:' | sed 's/host: //') +ifeq ($(findstring i686,$(HOST)),i686) +TARGET := $(subst i686,x86_64,$(HOST)) +else +TARGET := $(subst x86_64,i686,$(HOST)) +endif + +all: + $(RUSTC) foo.rs -C extra-filename=-host + $(RUSTC) bar.rs -C extra-filename=-targ --target $(TARGET) + $(RUSTC) baz.rs --extern a=$(TMPDIR)/liba-targ.rlib --target $(TARGET) diff --git a/src/test/run-make/use-extern-for-plugins/bar.rs b/src/test/run-make/use-extern-for-plugins/bar.rs new file mode 100644 index 00000000000..f279893b77b --- /dev/null +++ b/src/test/run-make/use-extern-for-plugins/bar.rs @@ -0,0 +1,19 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![feature(no_std)] +#![no_std] +#![crate_type = "lib"] +#![crate_name = "a"] + +#[macro_export] +macro_rules! bar { + () => () +} diff --git a/src/test/run-make/use-extern-for-plugins/baz.rs b/src/test/run-make/use-extern-for-plugins/baz.rs new file mode 100644 index 00000000000..89d6c6bc58c --- /dev/null +++ b/src/test/run-make/use-extern-for-plugins/baz.rs @@ -0,0 +1,18 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![feature(no_std)] +#![no_std] +#![crate_type = "lib"] + +#[macro_use] +extern crate a; + +bar!(); diff --git a/src/test/run-make/use-extern-for-plugins/foo.rs b/src/test/run-make/use-extern-for-plugins/foo.rs new file mode 100644 index 00000000000..554c0fe0326 --- /dev/null +++ b/src/test/run-make/use-extern-for-plugins/foo.rs @@ -0,0 +1,19 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![feature(no_std)] +#![no_std] +#![crate_type = "lib"] +#![crate_name = "a"] + +#[macro_export] +macro_rules! foo { + () => () +}