squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Auto merge of #83565 - RalfJung:miri, r=oli-obk

Browse source 
update Miri, and also run test suite with mir-opt-level=4

In the Miri repo, we run the Miri test suite once with default flags and once with `-O -Zmir-opt-level=4`. This helps identify and document situations where MIR optimizations mask UB -- it is okay for that to happen, but it might be god to look into it when it does happen. Recently these tests failed fairly frequently as new MIR optimizations were added, and since we only run them on the Miri side, it is not even clear which rustc PR introduced the change. So I propose we also run these tests in the rustc repo, such that toolstate tracking will tell us the exact PR (or at least the rollup) that caused the change.

r? `@oli-obk`
Fixes https://github.com/rust-lang/rust/issues/83590
This commit is contained in:
bors 2021-03-29 08:27:59 +00:00
commit 40334da7a6
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/bootstrap/test.rs
View file

@ -452,7 +452,14 @@ impl Step for Miri {
cargo.add_rustc_lib_path(builder, compiler);
if !try_run(builder, &mut cargo.into()) {
let mut cargo = Command::from(cargo);
if !try_run(builder, &mut cargo) {
return;
}
// # Run `cargo test` with `-Zmir-opt-level=4`.
cargo.env("MIRIFLAGS", "-O -Zmir-opt-level=4");
if !try_run(builder, &mut cargo) {
return;
}

2
src/tools/miri

@ -1 +1 @@
Subproject commit 12dac5c0f7acd106401aa14fec758f0ff552f678
Subproject commit 2cdd1744b896e8129322229f253f95fd7ad491f1