squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Add workaround for hidden outer attribute

Browse source 
If the snippet is empty, it's an attribute that was inserted during macro
expansion and we want to ignore those, because they could come from external
sources that the user has no control over.
For some reason these attributes don't have any expansion info on them, so
we have to check it this way until there is a better way.
This commit is contained in:
Philipp Hansch 2018-01-26 07:51:27 +01:00
parent aade0d563e
commit 3d54e56ed4
No known key found for this signature in database
GPG key ID: 667C8F4B5A698A60
1 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
clippy_lints/src/attrs.rs
View file

@ -263,6 +263,10 @@ fn check_attrs(cx: &LateContext, span: Span, name: &Name, attrs: &[Attribute]) {
for attr in attrs {
if attr.style == AttrStyle::Outer {
if !is_present_in_source(cx, attr.span) {
return;
}
let attr_to_item_span = Span::new(attr.span.lo(), span.lo(), span.ctxt());
if let Some(snippet) = snippet_opt(cx, attr_to_item_span) {
@ -319,3 +323,17 @@ fn is_word(nmi: &NestedMetaItem, expected: &str) -> bool {
false
}
}
// If the snippet is empty, it's an attribute that was inserted during macro
// expansion and we want to ignore those, because they could come from external
// sources that the user has no control over.
// For some reason these attributes don't have any expansion info on them, so
// we have to check it this way until there is a better way.
fn is_present_in_source(cx: &LateContext, span: Span) -> bool {
if let Some(snippet) = snippet_opt(cx, span) {
if snippet.is_empty() {
return false;
}
}
true
}