squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Fix typo in futex RwLock::write_contended.

Browse source 
I wrote `state` where I should've used `s`.

This removes the unnecessary `s` variable to prevent that mistake.

Fortunately, this typo didn't affect the correctness of the lock, as the
second half of the condition (!has_writers_waiting) is enough for
correctness, which explains why this mistake didn't show up during
testing.
This commit is contained in:
Mara Bos 2022-05-21 11:15:28 +02:00
parent 4f372b14de
commit 3b70c29103
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
library/std/src/sys/unix/locks/futex_rwlock.rs
View file

@ -208,9 +208,8 @@ impl RwLock {
// Don't go to sleep if the lock has become available,
// or if the writers waiting bit is no longer set.
let s = self.state.load(Relaxed);
if is_unlocked(state) || !has_writers_waiting(s) {
state = s;
state = self.state.load(Relaxed);
if is_unlocked(state) || !has_writers_waiting(state) {
continue;
}