squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Avoid double text edits when renaming mod declaration

Browse source
This commit is contained in:
Lukas Wirth 2021-03-10 15:49:01 +01:00
parent a9b1e5cde1
commit 3af69b5359
4 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
crates/hir/src/lib.rs
View file

@ -305,7 +305,6 @@ impl ModuleDef {
ModuleDef::Module(it) => it.name(db),
ModuleDef::Const(it) => it.name(db),
ModuleDef::Static(it) => it.name(db),
ModuleDef::BuiltinType(it) => Some(it.name()),
}
}

1
crates/ide/src/references/rename.rs
View file

@ -94,6 +94,7 @@ pub(crate) fn rename_with_semantics(
}
}
/// Called by the client when it is about to rename a file.
pub(crate) fn will_rename_file(
db: &RootDatabase,
file_id: FileId,

3
crates/rust-analyzer/src/config.rs
View file

@ -395,6 +395,9 @@ impl Config {
pub fn work_done_progress(&self) -> bool {
try_or!(self.caps.window.as_ref()?.work_done_progress?, false)
}
pub fn will_rename(&self) -> bool {
try_or!(self.caps.workspace.as_ref()?.file_operations.as_ref()?.will_rename?, false)
}
pub fn code_action_resolve(&self) -> bool {
try_or!(
self.caps

12
crates/rust-analyzer/src/handlers.rs
View file

@ -799,8 +799,18 @@ pub(crate) fn handle_rename(
let _p = profile::span("handle_rename");
let position = from_proto::file_position(&snap, params.text_document_position)?;
let change =
let mut change =
snap.analysis.rename(position, &*params.new_name)?.map_err(to_proto::rename_error)?;
// this is kind of a hack to prevent double edits from happening when moving files
// When a module gets renamed by renaming the mod declaration this causes the file to move
// which in turn will trigger a WillRenameFiles request to the server for which we reply with a
// a second identical set of renames, the client will then apply both edits causing incorrect edits
// with this we only emit source_file_edits in the WillRenameFiles response which will do the rename instead
// See https://github.com/microsoft/vscode-languageserver-node/issues/752 for more info
if !change.file_system_edits.is_empty() && snap.config.will_rename() {
change.source_file_edits.clear();
}
let workspace_edit = to_proto::workspace_edit(&snap, change)?;
Ok(Some(workspace_edit))
}