squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Fix possible issue where unnamed is_symbol_def would pop stack wrongly

Browse source 
This removes is_symbol_def as unnecessary.
This commit is contained in:
Ville Penttinen 2019-02-13 18:02:18 +02:00
parent 0c37a9cc28
commit 3973974de1
1 changed files with 1 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
crates/ra_ide_api/src/symbol_index.rs
View file

@ -200,16 +200,6 @@ fn is_type(kind: SyntaxKind) -> bool {
}
}
fn is_symbol_def(kind: SyntaxKind) -> bool {
match kind {
FN_DEF | STRUCT_DEF | ENUM_DEF | TRAIT_DEF | MODULE | TYPE_DEF | CONST_DEF | STATIC_DEF => {
true
}
_ => false,
}
}
/// The actual data that is stored in the index. It should be as compact as
/// possible.
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
@ -236,7 +226,7 @@ fn source_file_to_file_symbols(source_file: &SourceFile, file_id: FileId) -> Vec
}
WalkEvent::Leave(node) => {
if is_symbol_def(node.kind()) {
if to_symbol(node).is_some() {
stack.pop();
}
}