From e93dd34cd3acabe64e9166753e52964677232adf Mon Sep 17 00:00:00 2001
From: blake2-ppc <blake2-ppc>
Date: Wed, 17 Jul 2013 21:12:01 +0200
Subject: [PATCH 1/2] Fix warnings in libextra tests

Most of these are "unneccesary allocation" in bitv, for ~[false, ..] instead
of [false, ..].
---
 src/libextra/bitv.rs | 50 ++++++++++++++++++++++----------------------
 src/libextra/sort.rs |  1 -
 2 files changed, 25 insertions(+), 26 deletions(-)

diff --git a/src/libextra/bitv.rs b/src/libextra/bitv.rs
index 106b7c80f18..33a50f4e9ab 100644
--- a/src/libextra/bitv.rs
+++ b/src/libextra/bitv.rs
@@ -893,9 +893,9 @@ mod tests {
     #[test]
     fn test_1_element() {
         let mut act = Bitv::new(1u, false);
-        assert!(act.eq_vec(~[false]));
+        assert!(act.eq_vec([false]));
         act = Bitv::new(1u, true);
-        assert!(act.eq_vec(~[true]));
+        assert!(act.eq_vec([true]));
     }
 
     #[test]
@@ -913,11 +913,11 @@ mod tests {
 
         act = Bitv::new(10u, false);
         assert!((act.eq_vec(
-                    ~[false, false, false, false, false, false, false, false, false, false])));
+                    [false, false, false, false, false, false, false, false, false, false])));
         // all 1
 
         act = Bitv::new(10u, true);
-        assert!((act.eq_vec(~[true, true, true, true, true, true, true, true, true, true])));
+        assert!((act.eq_vec([true, true, true, true, true, true, true, true, true, true])));
         // mixed
 
         act = Bitv::new(10u, false);
@@ -926,7 +926,7 @@ mod tests {
         act.set(2u, true);
         act.set(3u, true);
         act.set(4u, true);
-        assert!((act.eq_vec(~[true, true, true, true, true, false, false, false, false, false])));
+        assert!((act.eq_vec([true, true, true, true, true, false, false, false, false, false])));
         // mixed
 
         act = Bitv::new(10u, false);
@@ -935,7 +935,7 @@ mod tests {
         act.set(7u, true);
         act.set(8u, true);
         act.set(9u, true);
-        assert!((act.eq_vec(~[false, false, false, false, false, true, true, true, true, true])));
+        assert!((act.eq_vec([false, false, false, false, false, true, true, true, true, true])));
         // mixed
 
         act = Bitv::new(10u, false);
@@ -943,7 +943,7 @@ mod tests {
         act.set(3u, true);
         act.set(6u, true);
         act.set(9u, true);
-        assert!((act.eq_vec(~[true, false, false, true, false, false, true, false, false, true])));
+        assert!((act.eq_vec([true, false, false, true, false, false, true, false, false, true])));
     }
 
     #[test]
@@ -953,14 +953,14 @@ mod tests {
 
         act = Bitv::new(31u, false);
         assert!(act.eq_vec(
-                ~[false, false, false, false, false, false, false, false, false, false, false,
+                [false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, false, false, false]));
         // all 1
 
         act = Bitv::new(31u, true);
         assert!(act.eq_vec(
-                ~[true, true, true, true, true, true, true, true, true, true, true, true, true,
+                [true, true, true, true, true, true, true, true, true, true, true, true, true,
                 true, true, true, true, true, true, true, true, true, true, true, true, true, true,
                 true, true, true, true]));
         // mixed
@@ -975,7 +975,7 @@ mod tests {
         act.set(6u, true);
         act.set(7u, true);
         assert!(act.eq_vec(
-                ~[true, true, true, true, true, true, true, true, false, false, false, false, false,
+                [true, true, true, true, true, true, true, true, false, false, false, false, false,
                 false, false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, false]));
         // mixed
@@ -990,7 +990,7 @@ mod tests {
         act.set(22u, true);
         act.set(23u, true);
         assert!(act.eq_vec(
-                ~[false, false, false, false, false, false, false, false, false, false, false,
+                [false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, true, true, true, true, true, true, true, true,
                 false, false, false, false, false, false, false]));
         // mixed
@@ -1004,7 +1004,7 @@ mod tests {
         act.set(29u, true);
         act.set(30u, true);
         assert!(act.eq_vec(
-                ~[false, false, false, false, false, false, false, false, false, false, false,
+                [false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, false, false, false, false, false, false, false,
                 false, true, true, true, true, true, true, true]));
         // mixed
@@ -1014,7 +1014,7 @@ mod tests {
         act.set(17u, true);
         act.set(30u, true);
         assert!(act.eq_vec(
-                ~[false, false, false, true, false, false, false, false, false, false, false, false,
+                [false, false, false, true, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, true, false, false, false, false, false, false,
                 false, false, false, false, false, false, true]));
     }
@@ -1026,14 +1026,14 @@ mod tests {
 
         act = Bitv::new(32u, false);
         assert!(act.eq_vec(
-                ~[false, false, false, false, false, false, false, false, false, false, false,
+                [false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, false, false, false, false]));
         // all 1
 
         act = Bitv::new(32u, true);
         assert!(act.eq_vec(
-                ~[true, true, true, true, true, true, true, true, true, true, true, true, true,
+                [true, true, true, true, true, true, true, true, true, true, true, true, true,
                 true, true, true, true, true, true, true, true, true, true, true, true, true, true,
                 true, true, true, true, true]));
         // mixed
@@ -1048,7 +1048,7 @@ mod tests {
         act.set(6u, true);
         act.set(7u, true);
         assert!(act.eq_vec(
-                ~[true, true, true, true, true, true, true, true, false, false, false, false, false,
+                [true, true, true, true, true, true, true, true, false, false, false, false, false,
                 false, false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, false, false]));
         // mixed
@@ -1063,7 +1063,7 @@ mod tests {
         act.set(22u, true);
         act.set(23u, true);
         assert!(act.eq_vec(
-                ~[false, false, false, false, false, false, false, false, false, false, false,
+                [false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, true, true, true, true, true, true, true, true,
                 false, false, false, false, false, false, false, false]));
         // mixed
@@ -1078,7 +1078,7 @@ mod tests {
         act.set(30u, true);
         act.set(31u, true);
         assert!(act.eq_vec(
-                ~[false, false, false, false, false, false, false, false, false, false, false,
+                [false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, false, false, false, false, false, false, false,
                 false, true, true, true, true, true, true, true, true]));
         // mixed
@@ -1089,7 +1089,7 @@ mod tests {
         act.set(30u, true);
         act.set(31u, true);
         assert!(act.eq_vec(
-                ~[false, false, false, true, false, false, false, false, false, false, false, false,
+                [false, false, false, true, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, true, false, false, false, false, false, false,
                 false, false, false, false, false, false, true, true]));
     }
@@ -1101,14 +1101,14 @@ mod tests {
 
         act = Bitv::new(33u, false);
         assert!(act.eq_vec(
-                ~[false, false, false, false, false, false, false, false, false, false, false,
+                [false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, false, false, false, false, false]));
         // all 1
 
         act = Bitv::new(33u, true);
         assert!(act.eq_vec(
-                ~[true, true, true, true, true, true, true, true, true, true, true, true, true,
+                [true, true, true, true, true, true, true, true, true, true, true, true, true,
                 true, true, true, true, true, true, true, true, true, true, true, true, true, true,
                 true, true, true, true, true, true]));
         // mixed
@@ -1123,7 +1123,7 @@ mod tests {
         act.set(6u, true);
         act.set(7u, true);
         assert!(act.eq_vec(
-                ~[true, true, true, true, true, true, true, true, false, false, false, false, false,
+                [true, true, true, true, true, true, true, true, false, false, false, false, false,
                 false, false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, false, false, false]));
         // mixed
@@ -1138,7 +1138,7 @@ mod tests {
         act.set(22u, true);
         act.set(23u, true);
         assert!(act.eq_vec(
-                ~[false, false, false, false, false, false, false, false, false, false, false,
+                [false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, true, true, true, true, true, true, true, true,
                 false, false, false, false, false, false, false, false, false]));
         // mixed
@@ -1153,7 +1153,7 @@ mod tests {
         act.set(30u, true);
         act.set(31u, true);
         assert!(act.eq_vec(
-                ~[false, false, false, false, false, false, false, false, false, false, false,
+                [false, false, false, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, false, false, false, false, false, false, false,
                 false, true, true, true, true, true, true, true, true, false]));
         // mixed
@@ -1165,7 +1165,7 @@ mod tests {
         act.set(31u, true);
         act.set(32u, true);
         assert!(act.eq_vec(
-                ~[false, false, false, true, false, false, false, false, false, false, false, false,
+                [false, false, false, true, false, false, false, false, false, false, false, false,
                 false, false, false, false, false, true, false, false, false, false, false, false,
                 false, false, false, false, false, false, true, true, true]));
     }
diff --git a/src/libextra/sort.rs b/src/libextra/sort.rs
index 4269447c7ea..56a906e0a5d 100644
--- a/src/libextra/sort.rs
+++ b/src/libextra/sort.rs
@@ -792,7 +792,6 @@ mod test_qsort {
 
     use sort::*;
 
-    use std::int;
     use std::vec;
 
     fn check_sort(v1: &mut [int], v2: &mut [int]) {

From ff9b75f26d8784c38ff6fbdb55511204f75a8a72 Mon Sep 17 00:00:00 2001
From: blake2-ppc <blake2-ppc>
Date: Wed, 17 Jul 2013 21:32:49 +0200
Subject: [PATCH 2/2] Fix warnings in libstd and librusti tests

---
 src/librusti/rusti.rs | 1 -
 src/libstd/hashmap.rs | 4 ++--
 src/libstd/os.rs      | 1 -
 src/libstd/ptr.rs     | 7 ++++---
 src/libstd/rand.rs    | 1 -
 src/libstd/to_str.rs  | 2 +-
 src/libstd/vec.rs     | 2 +-
 7 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/src/librusti/rusti.rs b/src/librusti/rusti.rs
index 1bee2146089..68f871125e1 100644
--- a/src/librusti/rusti.rs
+++ b/src/librusti/rusti.rs
@@ -546,7 +546,6 @@ pub fn main() {
 #[cfg(test)]
 mod tests {
     use std::io;
-    use std::iterator::IteratorUtil;
     use program::Program;
     use super::*;
 
diff --git a/src/libstd/hashmap.rs b/src/libstd/hashmap.rs
index 7cf2c594202..c81f40b6e59 100644
--- a/src/libstd/hashmap.rs
+++ b/src/libstd/hashmap.rs
@@ -863,7 +863,7 @@ pub type SetAlgebraIter<'self, T> =
 
 #[cfg(test)]
 mod test_map {
-    use container::{Container, Map, Set};
+    use container::{Container, Map};
     use option::{None, Some};
     use super::*;
     use uint;
@@ -1104,7 +1104,7 @@ mod test_map {
 #[cfg(test)]
 mod test_set {
     use super::*;
-    use container::{Container, Map, Set};
+    use container::Container;
     use vec::ImmutableEqVector;
     use uint;
 
diff --git a/src/libstd/os.rs b/src/libstd/os.rs
index a7e3fec51a7..25bd8f21680 100644
--- a/src/libstd/os.rs
+++ b/src/libstd/os.rs
@@ -1742,7 +1742,6 @@ mod tests {
     use rand;
     use run;
     use str::StrSlice;
-    use vec;
     use vec::CopyableVector;
     use libc::consts::os::posix88::{S_IRUSR, S_IWUSR, S_IXUSR};
 
diff --git a/src/libstd/ptr.rs b/src/libstd/ptr.rs
index caf15120bd7..15651e1aca4 100644
--- a/src/libstd/ptr.rs
+++ b/src/libstd/ptr.rs
@@ -16,8 +16,9 @@ use option::{Option, Some, None};
 use sys;
 use unstable::intrinsics;
 use util::swap;
-use ops::{Add,Sub};
-use num::Int;
+
+#[cfg(not(test))] use ops::{Add,Sub};
+#[cfg(not(test))] use num::Int;
 
 #[cfg(not(test))] use cmp::{Eq, Ord};
 use uint;
@@ -592,7 +593,7 @@ pub mod ptr_tests {
             }
 
             let mut xs_mut = xs.clone();
-            let mut m_start = to_mut_ptr(xs_mut);
+            let m_start = to_mut_ptr(xs_mut);
             let mut m_ptr = m_start + 9u32;
 
             while m_ptr >= m_start {
diff --git a/src/libstd/rand.rs b/src/libstd/rand.rs
index 76dbc629168..9583e37d002 100644
--- a/src/libstd/rand.rs
+++ b/src/libstd/rand.rs
@@ -1078,7 +1078,6 @@ mod tests {
         // This is to verify that the implementation of the ISAAC rng is
         // correct (i.e. matches the output of the upstream implementation,
         // which is in the runtime)
-        use vec;
         use libc::size_t;
 
         #[abi = "cdecl"]
diff --git a/src/libstd/to_str.rs b/src/libstd/to_str.rs
index b655dc828bf..227712e31e6 100644
--- a/src/libstd/to_str.rs
+++ b/src/libstd/to_str.rs
@@ -181,7 +181,7 @@ impl<A:ToStr> ToStr for @[A] {
 mod tests {
     use hashmap::HashMap;
     use hashmap::HashSet;
-    use container::{Set, Map, MutableSet, MutableMap};
+    use container::{MutableSet, MutableMap};
     #[test]
     fn test_simple_types() {
         assert_eq!(1i.to_str(), ~"1");
diff --git a/src/libstd/vec.rs b/src/libstd/vec.rs
index 085510171ee..cc73c28bba0 100644
--- a/src/libstd/vec.rs
+++ b/src/libstd/vec.rs
@@ -16,7 +16,7 @@ use cast::transmute;
 use cast;
 use clone::Clone;
 use container::{Container, Mutable};
-use cmp::{Eq, TotalEq, TotalOrd, Ordering, Less, Equal, Greater};
+use cmp::{Eq, TotalOrd, Ordering, Less, Equal, Greater};
 use cmp;
 use iterator::*;
 use libc::c_void;