squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Auto merge of #60346 - dima74:patch-1, r=GuillaumeGomez

Browse source 
Fix default value for setting "Auto-hide item methods' documentation"

If I open any documentation page in incognito mode (for example [for `Option` enum](https://doc.rust-lang.org/nightly/std/option/enum.Option.html)), then methods will be collapsed, though [on the settings page](https://doc.rust-lang.org/nightly/settings.html) there will be displayed that "Auto-hide item methods' documentation" option is disabled.

If I understand correctly, property "Auto-hide item methods' documentation" [should be disabled by default](938d4ffe16/src/librustdoc/html/render.rs (L1969)), so correct check would be `property === "true"`. This is consistent with other options:

Options which are enabled by default are compared to `"false"`

938d4ffe16/src/librustdoc/html/render.rs (L1965-L1968)

938d4ffe16/src/librustdoc/html/static/main.js (L2238)
938d4ffe16/src/librustdoc/html/static/main.js (L2321)
938d4ffe16/src/librustdoc/html/static/main.js (L2070)

Options which are disabled by default are compared to `"true"`

938d4ffe16/src/librustdoc/html/render.rs (L1970-L1972)

938d4ffe16/src/librustdoc/html/static/main.js (L1389)
938d4ffe16/src/librustdoc/html/static/main.js (L2334)
This commit is contained in:
bors 2019-04-28 09:58:59 +00:00
commit 3418d2f508
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/librustdoc/html/static/main.js
View file

@ -2105,7 +2105,7 @@ if (!DOMTokenList.prototype.remove) {
}
var toggle = createSimpleToggle(false);
var hideMethodDocs = getCurrentValue("rustdoc-method-docs") !== "false";
var hideMethodDocs = getCurrentValue("rustdoc-method-docs") === "true";
var pageId = getPageId();
var func = function(e) {