From da29402d2eec18c88c871ba83c417799b0798b4c Mon Sep 17 00:00:00 2001 From: flip1995 Date: Thu, 12 Mar 2020 21:01:19 +0100 Subject: [PATCH 1/3] Update CHANGELOG.md --- CHANGELOG.md | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 32cbbe80101..9bd8b681b13 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,75 @@ document. Current Beta +[69f99e7...329923e](https://github.com/rust-lang/rust-clippy/compare/69f99e7...329923e) + +* New Lints: + * [`filetype_is_file`] [#4543](https://github.com/rust-lang/rust-clippy/pull/4543) + * [`let_underscore_must_use`] [#4823](https://github.com/rust-lang/rust-clippy/pull/4823) + * [`modulo_arithmetic`] [#4867](https://github.com/rust-lang/rust-clippy/pull/4867) + * [`mem_replace_with_default`] [#4881](https://github.com/rust-lang/rust-clippy/pull/4881) + * [`mutable_key_type`] [#4885](https://github.com/rust-lang/rust-clippy/pull/4885) + * [`imprecise_flops`] [#4897](https://github.com/rust-lang/rust-clippy/pull/4897) + * [`suboptimal_flops`] [#4897](https://github.com/rust-lang/rust-clippy/pull/4897) + * [`option_as_ref_deref`] [#4945](https://github.com/rust-lang/rust-clippy/pull/4945) + * [`wildcard_in_or_patterns`] [#4960](https://github.com/rust-lang/rust-clippy/pull/4960) + * [`iter_nth_zero`] [#4966](https://github.com/rust-lang/rust-clippy/pull/4966) + * [`invalid_atomic_ordering`] [#4999](https://github.com/rust-lang/rust-clippy/pull/4999) + * [`wildcard_imports`] [#5029](https://github.com/rust-lang/rust-clippy/pull/5029) + * [`single_component_path_imports`] [#5058](https://github.com/rust-lang/rust-clippy/pull/5058) + * [`match_single_binding`] [#5061](https://github.com/rust-lang/rust-clippy/pull/5061) + * [`skip_while_next`] [#5067](https://github.com/rust-lang/rust-clippy/pull/5067) + * [`let_underscore_lock`] [#5101](https://github.com/rust-lang/rust-clippy/pull/5101) + * [`struct_excessive_bools`] [#5125](https://github.com/rust-lang/rust-clippy/pull/5125) + * [`fn_params_excessive_bools`] [#5125](https://github.com/rust-lang/rust-clippy/pull/5125) + * [`option_env_unwrap`] [#5148](https://github.com/rust-lang/rust-clippy/pull/5148) + * [`lossy_float_literal`] [#5202](https://github.com/rust-lang/rust-clippy/pull/5202) + * [`rest_pat_in_fully_bound_structs`] [#5258](https://github.com/rust-lang/rust-clippy/pull/5258) +* Move [`transmute_float_to_int`] from nursery to complexity group + [#5015](https://github.com/rust-lang/rust-clippy/pull/5015) +* Move [`range_plus_one`] to pedantic group [#5057](https://github.com/rust-lang/rust-clippy/pull/5057) +* Move [`unneeded_field_pattern`] to pedantic group [#5200](https://github.com/rust-lang/rust-clippy/pull/5200) +* Move [`debug_assert_with_mut_call`] to nursery group [#5106](https://github.com/rust-lang/rust-clippy/pull/5106) +* Deprecate [`unused_label`] [#4930](https://github.com/rust-lang/rust-clippy/pull/4930) +* Lint vectored IO in `unused_io_amount` [#5027](https://github.com/rust-lang/rust-clippy/pull/5027) +* Make `vec_box` configurable by adding a size threshold [#5081](https://github.com/rust-lang/rust-clippy/pull/5081) +* Make `missing_errors_doc` lint also trigger an `async` functions + [#5181](https://github.com/rust-lang/rust-clippy/pull/5181) +* Add more constants to `approx_constant` [#5193](https://github.com/rust-lang/rust-clippy/pull/5193) +* Extend `question_mark` lint [#5266](https://github.com/rust-lang/rust-clippy/pull/5266) +* Also lint constants in `cmp_nan` [#4910](https://github.com/rust-lang/rust-clippy/pull/4910) +* Fix false negative in `expect_fun_call` [#4915](https://github.com/rust-lang/rust-clippy/pull/4915) +* Fix false negative in `redundant_clone` [#5017](https://github.com/rust-lang/rust-clippy/pull/5017) +* Fix false positive in `map_clone` [#4937](https://github.com/rust-lang/rust-clippy/pull/4937) +* Fix false positive in `replace_consts` [#4977](https://github.com/rust-lang/rust-clippy/pull/4977) +* Fix false positive in `let_and_return` [#5008](https://github.com/rust-lang/rust-clippy/pull/5008) +* Fix false positive in `use_debug` [#5047](https://github.com/rust-lang/rust-clippy/pull/5047) +* Fix false positive in `eq_op` [#5079](https://github.com/rust-lang/rust-clippy/pull/5079) +* Fix false positive in `possible_missing_comma` [#5083](https://github.com/rust-lang/rust-clippy/pull/5083) +* Fix false positive in `debug_assert_with_mut_call` [#5106](https://github.com/rust-lang/rust-clippy/pull/5106) +* Fix false positive in `unnecessary_unwrap` [#5132](https://github.com/rust-lang/rust-clippy/pull/5132) +* Fix false positive in `zero_prefixed_literal` [#5170](https://github.com/rust-lang/rust-clippy/pull/5170) +* Fix false positive in `missing_const_for_fn` [#5216](https://github.com/rust-lang/rust-clippy/pull/5216) +* Don't trigger `let_underscore_must_use` in external macros + [#5082](https://github.com/rust-lang/rust-clippy/pull/5082) +* Don't trigger `empty_loop` in `no_std` crates [#5086](https://github.com/rust-lang/rust-clippy/pull/5086) +* Improve suggestion for `option_map_unwrap_or` [#4634](https://github.com/rust-lang/rust-clippy/pull/4634) +* Improve suggestion for `wildcard_enum_match_arm` [#4934](https://github.com/rust-lang/rust-clippy/pull/4934) +* Improve suggestion for `cognitive_complexity` [#4935](https://github.com/rust-lang/rust-clippy/pull/4935) +* Improve suggestion for `decimal_literal_representation` [#4956](https://github.com/rust-lang/rust-clippy/pull/4956) +* Improve suggestion for `unknown_clippy_lints` [#4963](https://github.com/rust-lang/rust-clippy/pull/4963) +* Improve suggestion for `explicit_into_iter_loop` [#4978](https://github.com/rust-lang/rust-clippy/pull/4978) +* Improve suggestion for `useless_attribute` [#5022](https://github.com/rust-lang/rust-clippy/pull/5022) +* Improve suggestion for `if_let_some_result` [#5032](https://github.com/rust-lang/rust-clippy/pull/5032) +* Improve suggestion when blocks of code are suggested [#5134](https://github.com/rust-lang/rust-clippy/pull/5134) +* Fix ICE in `unsound_collection_transmute` [#4975](https://github.com/rust-lang/rust-clippy/pull/4975) +* Fix ICE in `misc_early` lints [#5129](https://github.com/rust-lang/rust-clippy/pull/5129) +* Fix ICE in `missing_errors_doc` [#5213](https://github.com/rust-lang/rust-clippy/pull/5213) +* Fix ICE when evaluating `usize`s [#5256](https://github.com/rust-lang/rust-clippy/pull/5256) +* Improve documentation of `empty_enum`, `replace_consts`, `redundant_clone`, and `iterator_step_by_zero` +* Add documentation pages for stable releases [#5171](https://github.com/rust-lang/rust-clippy/pull/5171) +* Clippy now runs completely on GitHub Actions [#5190](https://github.com/rust-lang/rust-clippy/pull/5190) + ## Rust 1.41 Current stable, released 2020-01-30 From 6525127c624d24497256ec02eed571b3978c0168 Mon Sep 17 00:00:00 2001 From: flip1995 Date: Thu, 12 Mar 2020 21:02:08 +0100 Subject: [PATCH 2/3] Update changelog_update doc to reflect the actual ordering of the changelog --- doc/changelog_update.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/changelog_update.md b/doc/changelog_update.md index cabf25135da..5c7898fc465 100644 --- a/doc/changelog_update.md +++ b/doc/changelog_update.md @@ -55,10 +55,13 @@ try to keep it somewhat coherent. The order should roughly be: 1. New lints -2. Changes that expand what code existing lints cover -3. ICE fixes +2. Moves or deprecations of lints +3. Changes that expand what code existing lints cover 4. False positive fixes 5. Suggestion fixes/improvements +6. ICE fixes +7. Documentation improvements +8. Others Please also be sure to update the Beta/Unreleased sections at the top with the relevant commit ranges. From 7b08c7a36e22b4bdc573103ce327662f346b525a Mon Sep 17 00:00:00 2001 From: flip1995 Date: Thu, 12 Mar 2020 20:54:25 +0100 Subject: [PATCH 3/3] Change changelog formatting --- CHANGELOG.md | 131 ++++++++++++++++++++++++++++++--------------------- 1 file changed, 77 insertions(+), 54 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9bd8b681b13..c8d41e3b31d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,72 +14,95 @@ Current Beta [69f99e7...329923e](https://github.com/rust-lang/rust-clippy/compare/69f99e7...329923e) -* New Lints: - * [`filetype_is_file`] [#4543](https://github.com/rust-lang/rust-clippy/pull/4543) - * [`let_underscore_must_use`] [#4823](https://github.com/rust-lang/rust-clippy/pull/4823) - * [`modulo_arithmetic`] [#4867](https://github.com/rust-lang/rust-clippy/pull/4867) - * [`mem_replace_with_default`] [#4881](https://github.com/rust-lang/rust-clippy/pull/4881) - * [`mutable_key_type`] [#4885](https://github.com/rust-lang/rust-clippy/pull/4885) - * [`imprecise_flops`] [#4897](https://github.com/rust-lang/rust-clippy/pull/4897) - * [`suboptimal_flops`] [#4897](https://github.com/rust-lang/rust-clippy/pull/4897) - * [`option_as_ref_deref`] [#4945](https://github.com/rust-lang/rust-clippy/pull/4945) - * [`wildcard_in_or_patterns`] [#4960](https://github.com/rust-lang/rust-clippy/pull/4960) - * [`iter_nth_zero`] [#4966](https://github.com/rust-lang/rust-clippy/pull/4966) - * [`invalid_atomic_ordering`] [#4999](https://github.com/rust-lang/rust-clippy/pull/4999) - * [`wildcard_imports`] [#5029](https://github.com/rust-lang/rust-clippy/pull/5029) - * [`single_component_path_imports`] [#5058](https://github.com/rust-lang/rust-clippy/pull/5058) - * [`match_single_binding`] [#5061](https://github.com/rust-lang/rust-clippy/pull/5061) - * [`skip_while_next`] [#5067](https://github.com/rust-lang/rust-clippy/pull/5067) - * [`let_underscore_lock`] [#5101](https://github.com/rust-lang/rust-clippy/pull/5101) - * [`struct_excessive_bools`] [#5125](https://github.com/rust-lang/rust-clippy/pull/5125) - * [`fn_params_excessive_bools`] [#5125](https://github.com/rust-lang/rust-clippy/pull/5125) - * [`option_env_unwrap`] [#5148](https://github.com/rust-lang/rust-clippy/pull/5148) - * [`lossy_float_literal`] [#5202](https://github.com/rust-lang/rust-clippy/pull/5202) - * [`rest_pat_in_fully_bound_structs`] [#5258](https://github.com/rust-lang/rust-clippy/pull/5258) +### New lints + +* [`filetype_is_file`] [#4543](https://github.com/rust-lang/rust-clippy/pull/4543) +* [`let_underscore_must_use`] [#4823](https://github.com/rust-lang/rust-clippy/pull/4823) +* [`modulo_arithmetic`] [#4867](https://github.com/rust-lang/rust-clippy/pull/4867) +* [`mem_replace_with_default`] [#4881](https://github.com/rust-lang/rust-clippy/pull/4881) +* [`mutable_key_type`] [#4885](https://github.com/rust-lang/rust-clippy/pull/4885) +* [`imprecise_flops`] [#4897](https://github.com/rust-lang/rust-clippy/pull/4897) +* [`suboptimal_flops`] [#4897](https://github.com/rust-lang/rust-clippy/pull/4897) +* [`option_as_ref_deref`] [#4945](https://github.com/rust-lang/rust-clippy/pull/4945) +* [`wildcard_in_or_patterns`] [#4960](https://github.com/rust-lang/rust-clippy/pull/4960) +* [`iter_nth_zero`] [#4966](https://github.com/rust-lang/rust-clippy/pull/4966) +* [`invalid_atomic_ordering`] [#4999](https://github.com/rust-lang/rust-clippy/pull/4999) +* [`wildcard_imports`] [#5029](https://github.com/rust-lang/rust-clippy/pull/5029) +* [`single_component_path_imports`] [#5058](https://github.com/rust-lang/rust-clippy/pull/5058) +* [`match_single_binding`] [#5061](https://github.com/rust-lang/rust-clippy/pull/5061) +* [`skip_while_next`] [#5067](https://github.com/rust-lang/rust-clippy/pull/5067) +* [`let_underscore_lock`] [#5101](https://github.com/rust-lang/rust-clippy/pull/5101) +* [`struct_excessive_bools`] [#5125](https://github.com/rust-lang/rust-clippy/pull/5125) +* [`fn_params_excessive_bools`] [#5125](https://github.com/rust-lang/rust-clippy/pull/5125) +* [`option_env_unwrap`] [#5148](https://github.com/rust-lang/rust-clippy/pull/5148) +* [`lossy_float_literal`] [#5202](https://github.com/rust-lang/rust-clippy/pull/5202) +* [`rest_pat_in_fully_bound_structs`] [#5258](https://github.com/rust-lang/rust-clippy/pull/5258) + +### Moves and Deprecations + * Move [`transmute_float_to_int`] from nursery to complexity group [#5015](https://github.com/rust-lang/rust-clippy/pull/5015) * Move [`range_plus_one`] to pedantic group [#5057](https://github.com/rust-lang/rust-clippy/pull/5057) * Move [`unneeded_field_pattern`] to pedantic group [#5200](https://github.com/rust-lang/rust-clippy/pull/5200) * Move [`debug_assert_with_mut_call`] to nursery group [#5106](https://github.com/rust-lang/rust-clippy/pull/5106) * Deprecate [`unused_label`] [#4930](https://github.com/rust-lang/rust-clippy/pull/4930) -* Lint vectored IO in `unused_io_amount` [#5027](https://github.com/rust-lang/rust-clippy/pull/5027) -* Make `vec_box` configurable by adding a size threshold [#5081](https://github.com/rust-lang/rust-clippy/pull/5081) -* Make `missing_errors_doc` lint also trigger an `async` functions + +### Enhancements + +* Lint vectored IO in [`unused_io_amount`] [#5027](https://github.com/rust-lang/rust-clippy/pull/5027) +* Make [`vec_box`] configurable by adding a size threshold [#5081](https://github.com/rust-lang/rust-clippy/pull/5081) +* Make [`missing_errors_doc`] lint also trigger an `async` functions [#5181](https://github.com/rust-lang/rust-clippy/pull/5181) -* Add more constants to `approx_constant` [#5193](https://github.com/rust-lang/rust-clippy/pull/5193) -* Extend `question_mark` lint [#5266](https://github.com/rust-lang/rust-clippy/pull/5266) -* Also lint constants in `cmp_nan` [#4910](https://github.com/rust-lang/rust-clippy/pull/4910) -* Fix false negative in `expect_fun_call` [#4915](https://github.com/rust-lang/rust-clippy/pull/4915) -* Fix false negative in `redundant_clone` [#5017](https://github.com/rust-lang/rust-clippy/pull/5017) -* Fix false positive in `map_clone` [#4937](https://github.com/rust-lang/rust-clippy/pull/4937) -* Fix false positive in `replace_consts` [#4977](https://github.com/rust-lang/rust-clippy/pull/4977) -* Fix false positive in `let_and_return` [#5008](https://github.com/rust-lang/rust-clippy/pull/5008) -* Fix false positive in `use_debug` [#5047](https://github.com/rust-lang/rust-clippy/pull/5047) -* Fix false positive in `eq_op` [#5079](https://github.com/rust-lang/rust-clippy/pull/5079) -* Fix false positive in `possible_missing_comma` [#5083](https://github.com/rust-lang/rust-clippy/pull/5083) -* Fix false positive in `debug_assert_with_mut_call` [#5106](https://github.com/rust-lang/rust-clippy/pull/5106) -* Fix false positive in `unnecessary_unwrap` [#5132](https://github.com/rust-lang/rust-clippy/pull/5132) -* Fix false positive in `zero_prefixed_literal` [#5170](https://github.com/rust-lang/rust-clippy/pull/5170) -* Fix false positive in `missing_const_for_fn` [#5216](https://github.com/rust-lang/rust-clippy/pull/5216) -* Don't trigger `let_underscore_must_use` in external macros +* Add more constants to [`approx_constant`] [#5193](https://github.com/rust-lang/rust-clippy/pull/5193) +* Extend [`question_mark`] lint [#5266](https://github.com/rust-lang/rust-clippy/pull/5266) +* Also lint constants in [`cmp_nan`] [#4910](https://github.com/rust-lang/rust-clippy/pull/4910) +* Fix false negative in [`expect_fun_call`] [#4915](https://github.com/rust-lang/rust-clippy/pull/4915) +* Fix false negative in [`redundant_clone`] [#5017](https://github.com/rust-lang/rust-clippy/pull/5017) + +### False Positive Fixes + +* [`map_clone`] [#4937](https://github.com/rust-lang/rust-clippy/pull/4937) +* [`replace_consts`] [#4977](https://github.com/rust-lang/rust-clippy/pull/4977) +* [`let_and_return`] [#5008](https://github.com/rust-lang/rust-clippy/pull/5008) +* [`use_debug`] [#5047](https://github.com/rust-lang/rust-clippy/pull/5047) +* [`eq_op`] [#5079](https://github.com/rust-lang/rust-clippy/pull/5079) +* [`possible_missing_comma`] [#5083](https://github.com/rust-lang/rust-clippy/pull/5083) +* [`debug_assert_with_mut_call`] [#5106](https://github.com/rust-lang/rust-clippy/pull/5106) +* [`unnecessary_unwrap`] [#5132](https://github.com/rust-lang/rust-clippy/pull/5132) +* [`zero_prefixed_literal`] [#5170](https://github.com/rust-lang/rust-clippy/pull/5170) +* [`missing_const_for_fn`] [#5216](https://github.com/rust-lang/rust-clippy/pull/5216) +* Don't trigger [`let_underscore_must_use`] in external macros [#5082](https://github.com/rust-lang/rust-clippy/pull/5082) -* Don't trigger `empty_loop` in `no_std` crates [#5086](https://github.com/rust-lang/rust-clippy/pull/5086) -* Improve suggestion for `option_map_unwrap_or` [#4634](https://github.com/rust-lang/rust-clippy/pull/4634) -* Improve suggestion for `wildcard_enum_match_arm` [#4934](https://github.com/rust-lang/rust-clippy/pull/4934) -* Improve suggestion for `cognitive_complexity` [#4935](https://github.com/rust-lang/rust-clippy/pull/4935) -* Improve suggestion for `decimal_literal_representation` [#4956](https://github.com/rust-lang/rust-clippy/pull/4956) -* Improve suggestion for `unknown_clippy_lints` [#4963](https://github.com/rust-lang/rust-clippy/pull/4963) -* Improve suggestion for `explicit_into_iter_loop` [#4978](https://github.com/rust-lang/rust-clippy/pull/4978) -* Improve suggestion for `useless_attribute` [#5022](https://github.com/rust-lang/rust-clippy/pull/5022) -* Improve suggestion for `if_let_some_result` [#5032](https://github.com/rust-lang/rust-clippy/pull/5032) +* Don't trigger [`empty_loop`] in `no_std` crates [#5086](https://github.com/rust-lang/rust-clippy/pull/5086) + +### Suggestion Improvements + +* [`option_map_unwrap_or`] [#4634](https://github.com/rust-lang/rust-clippy/pull/4634) +* [`wildcard_enum_match_arm`] [#4934](https://github.com/rust-lang/rust-clippy/pull/4934) +* [`cognitive_complexity`] [#4935](https://github.com/rust-lang/rust-clippy/pull/4935) +* [`decimal_literal_representation`] [#4956](https://github.com/rust-lang/rust-clippy/pull/4956) +* [`unknown_clippy_lints`] [#4963](https://github.com/rust-lang/rust-clippy/pull/4963) +* [`explicit_into_iter_loop`] [#4978](https://github.com/rust-lang/rust-clippy/pull/4978) +* [`useless_attribute`] [#5022](https://github.com/rust-lang/rust-clippy/pull/5022) +* [`if_let_some_result`] [#5032](https://github.com/rust-lang/rust-clippy/pull/5032) * Improve suggestion when blocks of code are suggested [#5134](https://github.com/rust-lang/rust-clippy/pull/5134) -* Fix ICE in `unsound_collection_transmute` [#4975](https://github.com/rust-lang/rust-clippy/pull/4975) -* Fix ICE in `misc_early` lints [#5129](https://github.com/rust-lang/rust-clippy/pull/5129) -* Fix ICE in `missing_errors_doc` [#5213](https://github.com/rust-lang/rust-clippy/pull/5213) + +### ICE fixes + +* [`unsound_collection_transmute`] [#4975](https://github.com/rust-lang/rust-clippy/pull/4975) +* `misc_early` lints [#5129](https://github.com/rust-lang/rust-clippy/pull/5129) +* [`missing_errors_doc`] [#5213](https://github.com/rust-lang/rust-clippy/pull/5213) * Fix ICE when evaluating `usize`s [#5256](https://github.com/rust-lang/rust-clippy/pull/5256) + +### Documentation + * Improve documentation of `empty_enum`, `replace_consts`, `redundant_clone`, and `iterator_step_by_zero` * Add documentation pages for stable releases [#5171](https://github.com/rust-lang/rust-clippy/pull/5171) -* Clippy now runs completely on GitHub Actions [#5190](https://github.com/rust-lang/rust-clippy/pull/5190) + +### Others + +* Clippy now completely runs on GitHub Actions [#5190](https://github.com/rust-lang/rust-clippy/pull/5190) + ## Rust 1.41