squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Add more heuristics for hiding obvious param hints

Browse source 
This will now hide "value", "pat", "rhs" and "other"
These words were selected from the std because they are used in common functions with only a single param and are obvious by their use.
I think it would be good to also hide "bytes" if the type is `[u8; n]` but I'm not sure how to get the param type signature

It will also hide the hint if the passed param starts or end with the param_name
This commit is contained in:
IceSentry 2020-04-08 17:48:16 -04:00
parent 779555c1be
commit 2a582b78a5
1 changed files with 30 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
crates/ra_ide/src/inlay_hints.rs
View file

@ -1,4 +1,4 @@
//! FIXME: write short doc here
//! This module defines multiple types of inlay hints and their visibility
use hir::{Adt, HirDisplay, Semantics, Type};
use ra_ide_db::RootDatabase;
@ -236,7 +236,10 @@ fn should_show_param_hint(
argument: &ast::Expr,
) -> bool {
let argument_string = argument.syntax().to_string();
if param_name.is_empty() || argument_string.ends_with(param_name) {
if param_name.is_empty()
|| argument_string.ends_with(&param_name)
|| argument_string.starts_with(&param_name)
{
return false;
}
@ -245,8 +248,15 @@ fn should_show_param_hint(
} else {
fn_signature.parameters.len()
};
// avoid displaying hints for common functions like map, filter, etc.
if parameters_len == 1 && (param_name.len() == 1 || param_name == "predicate") {
// or other obvious words used in std
// TODO ignore "bytes" if the type is [u8; n]
let is_obvious_param_name = match param_name {
"predicate" | "value" | "pat" | "rhs" | "other" => true,
_ => false,
};
if parameters_len == 1 && (param_name.len() == 1 || is_obvious_param_name) {
return false;
}
@ -1059,9 +1069,17 @@ impl Test {
self
}
fn field(self, value: i32) -> Self {
self
}
fn no_hints_expected(&self, _: i32, test_var: i32) {}
}
struct Param {}
fn different_order(param: Param) {}
fn main() {
let container: TestVarContainer = TestVarContainer { test_var: 42 };
let test: Test = Test {};
@ -1069,11 +1087,19 @@ fn main() {
map(22);
filter(33);
let test_processed: Test = test.map(1).filter(2);
let test_processed: Test = test.map(1).filter(2).field(3);
let test_var: i32 = 55;
test_processed.no_hints_expected(22, test_var);
test_processed.no_hints_expected(33, container.test_var);
let param_begin: Param = Param {};
different_order(param_begin);
let a: f64 = 7.0;
let b: f64 = 4.0;
let _: f64 = a.div_euclid(b);
let _: f64 = a.abs_sub(b);
}"#,
);