squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Re-implementing str::to_upper and str::to_lower using str::map

Browse source
This commit is contained in:
Kevin Cantu 2012-01-30 22:26:42 -08:00 committed by Brian Anderson
parent a8b657397a
commit 1f795ff3b0
1 changed files with 11 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/libcore/str.rs
View file

@ -674,30 +674,18 @@ fn windowed(nn: uint, ss: str) -> [str] {
Function: to_lower
Convert a string to lowercase
FIXME: rewrite with map
*/
fn to_lower(s: str) -> str {
let outstr = "";
chars_iter(s) { |c|
push_char(outstr, char::to_lower(c));
}
ret outstr;
map(s, char::to_lower)
}
/*
Function: to_upper
Convert a string to uppercase
FIXME: rewrite with map
*/
fn to_upper(s: str) -> str {
let outstr = "";
chars_iter(s) { |c|
push_char(outstr, char::to_upper(c));
}
ret outstr;
map(s, char::to_upper)
}
// FIXME: This is super-inefficient
@ -1583,8 +1571,9 @@ mod tests {
#[test]
fn test_to_upper() {
// to_upper doesn't understand unicode yet,
// but we need to at least preserve it
// char::to_upper, and hence str::to_upper
// are culturally insensitive: I'm not sure they
// really work for anything but English ASCII, but YMMV
let unicode = "\u65e5\u672c";
let input = "abcDEF" + unicode + "xyz:.;";
@ -1593,6 +1582,12 @@ mod tests {
assert (eq(expected, actual));
}
#[test]
fn test_to_lower() {
assert "" == map("", char::to_lower);
assert "ymca" == map("YMCA", char::to_lower);
}
#[test]
fn test_slice() {
assert (eq("ab", slice("abc", 0u, 2u)));