squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Apply suggested wording

Browse source 
to better describe the situation
This commit is contained in:
BO41 2019-10-18 16:55:08 +00:00 committed by GitHub
parent 59ce359c8f
commit 1c85b45117
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
CONTRIBUTING.md
View file

@ -130,8 +130,10 @@ Also, please make sure that fixup commits are squashed into other related
commits with meaningful commit messages.
GitHub allows [closing issues using keywords][closing-keywords]. This feature
should be used to keep the issue tracker tidy. But in pull requests only. Please
do not add this to your commit message.
should be used to keep the issue tracker tidy. However, it is generally preferred
to put the "closes #123" text in the PR description rather than the issue commit;
particularly during rebasing, citing the issue number in the commit can "spam"
the issue in question.
[closing-keywords]: https://help.github.com/en/articles/closing-issues-using-keywords