squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

[resolve] Use unwrap_or_else instead of unwrap_or in a hot path

Browse source 
This improves the performance of the `resolve_crate` function by 30% for
a very large single file crate with auto-generated C bindings.
This commit is contained in:
Wesley Wiser 2020-10-28 08:53:55 -04:00
parent 31ee872db5
commit 1c1c591c81
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
compiler/rustc_resolve/src/lib.rs
View file

@ -1725,10 +1725,9 @@ impl<'a> Resolver<'a> {
Scope::MacroRules(binding.parent_macro_rules_scope)
}
MacroRulesScope::Invocation(invoc_id) => Scope::MacroRules(
self.output_macro_rules_scopes
.get(&invoc_id)
.cloned()
.unwrap_or(self.invocation_parent_scopes[&invoc_id].macro_rules),
self.output_macro_rules_scopes.get(&invoc_id).cloned().unwrap_or_else(
|| self.invocation_parent_scopes[&invoc_id].macro_rules,
),
),
MacroRulesScope::Empty => Scope::Module(module),
},