move PATTERN_METHODS table directly into file
also removed rustfmt::skip
This commit is contained in:
parent
c080899848
commit
19e7448c7f
2 changed files with 23 additions and 24 deletions
|
@ -2189,29 +2189,6 @@ const TRAIT_METHODS: [ShouldImplTraitCase; 30] = [
|
||||||
ShouldImplTraitCase::new("std::ops::Sub", "sub", 2, FN_HEADER, SelfKind::Value, OutType::Any, true),
|
ShouldImplTraitCase::new("std::ops::Sub", "sub", 2, FN_HEADER, SelfKind::Value, OutType::Any, true),
|
||||||
];
|
];
|
||||||
|
|
||||||
#[rustfmt::skip]
|
|
||||||
const PATTERN_METHODS: [(&str, usize); 19] = [
|
|
||||||
("contains", 1),
|
|
||||||
("starts_with", 1),
|
|
||||||
("ends_with", 1),
|
|
||||||
("find", 1),
|
|
||||||
("rfind", 1),
|
|
||||||
("split", 1),
|
|
||||||
("rsplit", 1),
|
|
||||||
("split_terminator", 1),
|
|
||||||
("rsplit_terminator", 1),
|
|
||||||
("splitn", 2),
|
|
||||||
("rsplitn", 2),
|
|
||||||
("matches", 1),
|
|
||||||
("rmatches", 1),
|
|
||||||
("match_indices", 1),
|
|
||||||
("rmatch_indices", 1),
|
|
||||||
("strip_prefix", 1),
|
|
||||||
("strip_suffix", 1),
|
|
||||||
("trim_start_matches", 1),
|
|
||||||
("trim_end_matches", 1),
|
|
||||||
];
|
|
||||||
|
|
||||||
#[derive(Clone, Copy, PartialEq, Debug)]
|
#[derive(Clone, Copy, PartialEq, Debug)]
|
||||||
enum SelfKind {
|
enum SelfKind {
|
||||||
Value,
|
Value,
|
||||||
|
|
|
@ -9,9 +9,31 @@ use rustc_span::symbol::Symbol;
|
||||||
|
|
||||||
use super::SINGLE_CHAR_PATTERN;
|
use super::SINGLE_CHAR_PATTERN;
|
||||||
|
|
||||||
|
const PATTERN_METHODS: [(&str, usize); 19] = [
|
||||||
|
("contains", 1),
|
||||||
|
("starts_with", 1),
|
||||||
|
("ends_with", 1),
|
||||||
|
("find", 1),
|
||||||
|
("rfind", 1),
|
||||||
|
("split", 1),
|
||||||
|
("rsplit", 1),
|
||||||
|
("split_terminator", 1),
|
||||||
|
("rsplit_terminator", 1),
|
||||||
|
("splitn", 2),
|
||||||
|
("rsplitn", 2),
|
||||||
|
("matches", 1),
|
||||||
|
("rmatches", 1),
|
||||||
|
("match_indices", 1),
|
||||||
|
("rmatch_indices", 1),
|
||||||
|
("strip_prefix", 1),
|
||||||
|
("strip_suffix", 1),
|
||||||
|
("trim_start_matches", 1),
|
||||||
|
("trim_end_matches", 1),
|
||||||
|
];
|
||||||
|
|
||||||
/// lint for length-1 `str`s for methods in `PATTERN_METHODS`
|
/// lint for length-1 `str`s for methods in `PATTERN_METHODS`
|
||||||
pub(super) fn check(cx: &LateContext<'_>, _expr: &hir::Expr<'_>, method_name: Symbol, args: &[hir::Expr<'_>]) {
|
pub(super) fn check(cx: &LateContext<'_>, _expr: &hir::Expr<'_>, method_name: Symbol, args: &[hir::Expr<'_>]) {
|
||||||
for &(method, pos) in &crate::methods::PATTERN_METHODS {
|
for &(method, pos) in &PATTERN_METHODS {
|
||||||
if_chain! {
|
if_chain! {
|
||||||
if let ty::Ref(_, ty, _) = cx.typeck_results().expr_ty_adjusted(&args[0]).kind();
|
if let ty::Ref(_, ty, _) = cx.typeck_results().expr_ty_adjusted(&args[0]).kind();
|
||||||
if *ty.kind() == ty::Str;
|
if *ty.kind() == ty::Str;
|
||||||
|
|
Loading…
Reference in a new issue