squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Rollup merge of #87180 - notriddle:notriddle/sidebar-keyboard-mobile, r=GuillaumeGomez

Browse source 
feat(rustdoc): open sidebar menu when links inside it are focused

Fixes #87172

Based on #87167 (which should be merged first)

r? ``@GuillaumeGomez``

Preview it at https://notriddle.com/notriddle-rustdoc-test/std/index.html
This commit is contained in:
Guillaume Gomez 2021-07-16 19:54:08 +02:00 committed by GitHub
commit 12ed22ffe4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/librustdoc/html/static/css/rustdoc.css
View file

@ -1732,7 +1732,8 @@ details.undocumented[open] > summary::before {
width: calc(100% + 30px);
}
.show-it {
.show-it, .sidebar-elems:focus-within {
z-index: 2;
left: 0;
}

10
src/test/rustdoc-gui/sidebar-mobile.goml
View file

@ -8,3 +8,13 @@ assert-css: (".sidebar-elems", {"display": "block", "left": "-246px"})
// Opening the sidebar menu.
click: ".sidebar-menu"
assert-css: (".sidebar-elems", {"display": "block", "left": "0px"})
// Closing the sidebar menu.
click: ".sidebar-menu"
assert-css: (".sidebar-elems", {"display": "block", "left": "-246px"})
// Force the sidebar open by focusing a link inside it.
// This makes it easier for keyboard users to get to it.
focus: ".sidebar-title"
assert-css: (".sidebar-elems", {"display": "block", "left": "0px"})
// When we tab out of the sidebar, close it.
focus: ".search-input"
assert-css: (".sidebar-elems", {"display": "block", "left": "-246px"})