squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Clippy: Match on assert!() expansions without an inner block.

Browse source
This commit is contained in:
Mara Bos 2020-11-19 19:47:25 +01:00
parent 78faaef8de
commit 113c1476c9
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
clippy_lints/src/assertions_on_constants.rs
View file

@ -129,8 +129,11 @@ fn match_assert_with_message<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>)
if let ExprKind::Block(ref block, _) = arms[0].body.kind; if let ExprKind::Block(ref block, _) = arms[0].body.kind;
if block.stmts.is_empty(); if block.stmts.is_empty();
if let Some(block_expr) = &block.expr; if let Some(block_expr) = &block.expr;
if let ExprKind::Block(ref inner_block, _) = block_expr.kind; // inner block is optional. unwarp it if it exists, or use the expression as is otherwise.
if let Some(begin_panic_call) = &inner_block.expr; if let Some(begin_panic_call) = match block_expr.kind {
ExprKind::Block(ref inner_block, _) => &inner_block.expr,
_ => &block.expr,
};
// function call // function call
if let Some(args) = match_panic_call(cx, begin_panic_call); if let Some(args) = match_panic_call(cx, begin_panic_call);
if args.len() == 1; if args.len() == 1;