squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Auto merge of #6023 - matthiaskrgr:box, r=flip1995

Browse source 
link to the Box docs in related lint documentation.

changelog: link to the box docs in lint docs
This commit is contained in:
bors 2020-09-10 13:49:50 +00:00
parent 87a4495b5d 4db10297c1
commit 0e9769e787
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
clippy_lints/src/types.rs
View file

@ -37,6 +37,7 @@ use crate::utils::{
declare_clippy_lint! {
/// **What it does:** Checks for use of `Box<Vec<_>>` anywhere in the code.
/// Check the [Box documentation](https://doc.rust-lang.org/std/boxed/index.html) for more information.
///
/// **Why is this bad?** `Vec` already keeps its contents in a separate area on
/// the heap. So if you `Box` it, you just add another level of indirection
@ -65,6 +66,7 @@ declare_clippy_lint! {
declare_clippy_lint! {
/// **What it does:** Checks for use of `Vec<Box<T>>` where T: Sized anywhere in the code.
/// Check the [Box documentation](https://doc.rust-lang.org/std/boxed/index.html) for more information.
///
/// **Why is this bad?** `Vec` already keeps its contents in a separate area on
/// the heap. So if you `Box` its contents, you just add another level of indirection.
@ -167,6 +169,7 @@ declare_clippy_lint! {
declare_clippy_lint! {
/// **What it does:** Checks for use of `&Box<T>` anywhere in the code.
/// Check the [Box documentation](https://doc.rust-lang.org/std/boxed/index.html) for more information.
///
/// **Why is this bad?** Any `&Box<T>` can also be a `&T`, which is more
/// general.