From 0d9f56674daf4acb7d2fdfdcee2211052837b873 Mon Sep 17 00:00:00 2001 From: Zaki Manian Date: Sun, 3 Sep 2017 14:01:29 -0700 Subject: [PATCH] Mention the false positive --- clippy_lints/src/is_unit_expr.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clippy_lints/src/is_unit_expr.rs b/clippy_lints/src/is_unit_expr.rs index abaa1edf090..4f3c755d731 100644 --- a/clippy_lints/src/is_unit_expr.rs +++ b/clippy_lints/src/is_unit_expr.rs @@ -134,6 +134,8 @@ fn is_unit_expr(expr: &Expr) -> Option { fn check_last_stmt_in_block(block: &Block) -> bool { let final_stmt = &block.stmts[block.stmts.len() - 1]; + + //Made a choice here to risk false positives on divergent macro invocations like `panic!()` match final_stmt.node { StmtKind::Expr(_) => false, StmtKind::Semi(ref expr) => match expr.node {