squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Avoid generating new strings for names that have no undescores

Browse source 
This should have negligible effect on time, but it cuts about 1MiB
off of resident memory usage.
This commit is contained in:
Michael Howell 2021-03-14 09:48:48 -07:00
parent d92f8405ce
commit 0bfd142926
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/librustdoc/html/static/main.js
View file

@ -1852,6 +1852,9 @@ function defocusSearchBar() {
var crateSize = 0;
searchWords.push(crate);
var nameWithoutUnderscores = crate.indexOf("_") === -1
? crate
: crate.replace(/_/g, "");
// This object should have exactly the same set of fields as the "row"
// object defined below. Your JavaScript runtime will thank you.
// https://mathiasbynens.be/notes/shapes-ics
@ -1864,7 +1867,7 @@ function defocusSearchBar() {
parent: undefined,
type: null,
id: "",
nameWithoutUnderscores: crate.replace(/_/g, ""),
nameWithoutUnderscores: nameWithoutUnderscores,
};
crateRow.id = generateId(crateRow);
searchIndex.push(crateRow);
@ -1907,6 +1910,9 @@ function defocusSearchBar() {
for (i = 0; i < len; ++i) {
// This object should have exactly the same set of fields as the "crateRow"
// object defined above.
var nameWithoutUnderscores = itemNames[i].indexOf("_") === -1
? itemNames[i]
: itemNames[i].replace(/_/g, "");
var row = {
crate: crate,
ty: itemTypes[i],
@ -1916,7 +1922,7 @@ function defocusSearchBar() {
parent: itemParentIdxs[i] > 0 ? paths[itemParentIdxs[i] - 1] : undefined,
type: itemFunctionSearchTypes[i],
id: "",
nameWithoutUnderscores: itemNames[i].replace(/_/g, ""),
nameWithoutUnderscores: nameWithoutUnderscores,
};
row.id = generateId(row);
searchIndex.push(row);