squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Avoid an extra alloca/memcpy when auto-ref'ing fat pointers

Browse source 
auto_ref() handles fat pointers just fine and unlike ref_fat_ptr() does so
without creating an unnecessary copy of the pointer.
This commit is contained in:
Björn Steinbrink 2015-08-26 19:41:27 +02:00
parent ef3255b063
commit 05d36965df
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/librustc_trans/trans/expr.rs
View file

@ -390,14 +390,7 @@ fn apply_adjustments<'blk, 'tcx>(bcx: Block<'blk, 'tcx>,
// (You might think there is a more elegant way to do this than a
// skip_reborrows bool, but then you remember that the borrow checker exists).
if skip_reborrows == 0 && adj.autoref.is_some() {
if !type_is_sized(bcx.tcx(), datum.ty) {
// Arrange cleanup
let lval = unpack_datum!(bcx,
datum.to_lvalue_datum(bcx, "ref_fat_ptr", expr.id));
datum = unpack_datum!(bcx, ref_fat_ptr(bcx, lval));
} else {
datum = unpack_datum!(bcx, auto_ref(bcx, datum, expr));
}
datum = unpack_datum!(bcx, auto_ref(bcx, datum, expr));
}
if let Some(target) = adj.unsize {