squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Check if the attribute is applied correctly

Browse source
This commit is contained in:
Deadbeef 2021-07-10 11:13:52 +08:00
parent 56d79adf3b
commit 032cbe4cce
No known key found for this signature in database
GPG key ID: 6525773485376D92
1 changed files with 26 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
compiler/rustc_passes/src/check_attr.rs
View file

@ -98,6 +98,9 @@ impl CheckAttrVisitor<'tcx> {
| sym::rustc_if_this_changed
| sym::rustc_then_this_would_need => self.check_rustc_dirty_clean(&attr),
sym::cmse_nonsecure_entry => self.check_cmse_nonsecure_entry(attr, span, target),
sym::default_method_body_is_const => {
self.check_default_method_body_is_const(attr, span, target)
}
_ => true,
};
// lint-only checks
@ -1465,6 +1468,29 @@ impl CheckAttrVisitor<'tcx> {
}
}
}
/// default_method_body_is_const should only be applied to trait methods with default bodies.
fn check_default_method_body_is_const(
&self,
attr: &Attribute,
span: &Span,
target: Target,
) -> bool {
match target {
Target::Method(MethodKind::Trait { body: true }) => true,
_ => {
self.tcx
.sess
.struct_span_err(
attr.span,
"attribute should be applied to a trait method with body",
)
.span_label(*span, "not a trait method or missing a body")
.emit();
false
}
}
}
}
impl Visitor<'tcx> for CheckAttrVisitor<'tcx> {