rust/tests/ui/needless_bool.rs

144 lines
2.5 KiB
Rust
Raw Normal View History

#![warn(clippy::needless_bool)]
2018-10-11 12:16:22 +02:00
use std::cell::Cell;
2017-09-18 12:47:33 +02:00
macro_rules! bool_comparison_trigger {
($($i:ident: $def:expr, $stb:expr );+ $(;)*) => (
#[derive(Clone)]
pub struct Trigger {
$($i: (Cell<bool>, bool, bool)),+
}
#[allow(dead_code)]
impl Trigger {
pub fn trigger(&self, key: &str) -> bool {
$(
if let stringify!($i) = key {
return self.$i.1 && self.$i.2 == $def;
}
)+
false
}
}
)
}
2017-09-18 12:47:33 +02:00
2018-07-28 17:34:52 +02:00
#[allow(clippy::if_same_then_else)]
fn main() {
let x = true;
2016-07-04 01:17:31 +02:00
let y = false;
2018-12-09 23:26:16 +01:00
if x {
true
} else {
true
};
if x {
false
} else {
false
};
if x {
true
} else {
false
};
if x {
false
} else {
true
};
if x && y {
false
} else {
true
};
if x {
x
} else {
false
}; // would also be questionable, but we don't catch this yet
bool_ret(x);
bool_ret2(x);
bool_ret3(x);
2016-07-04 01:17:31 +02:00
bool_ret5(x, x);
bool_ret4(x);
2016-07-04 01:17:31 +02:00
bool_ret6(x, x);
needless_bool(x);
needless_bool2(x);
needless_bool3(x);
}
2018-07-28 17:34:52 +02:00
#[allow(clippy::if_same_then_else, clippy::needless_return)]
fn bool_ret(x: bool) -> bool {
2018-12-09 23:26:16 +01:00
if x {
return true;
} else {
return true;
};
}
2018-07-28 17:34:52 +02:00
#[allow(clippy::if_same_then_else, clippy::needless_return)]
fn bool_ret2(x: bool) -> bool {
2018-12-09 23:26:16 +01:00
if x {
return false;
} else {
return false;
};
}
2018-07-28 17:34:52 +02:00
#[allow(clippy::needless_return)]
fn bool_ret3(x: bool) -> bool {
2018-12-09 23:26:16 +01:00
if x {
return true;
} else {
return false;
};
2016-07-04 01:17:31 +02:00
}
2018-07-28 17:34:52 +02:00
#[allow(clippy::needless_return)]
2016-07-04 01:17:31 +02:00
fn bool_ret5(x: bool, y: bool) -> bool {
2018-12-09 23:26:16 +01:00
if x && y {
return true;
} else {
return false;
};
}
2018-07-28 17:34:52 +02:00
#[allow(clippy::needless_return)]
fn bool_ret4(x: bool) -> bool {
2018-12-09 23:26:16 +01:00
if x {
return false;
} else {
return true;
};
2016-07-04 01:17:31 +02:00
}
2018-07-28 17:34:52 +02:00
#[allow(clippy::needless_return)]
2016-07-04 01:17:31 +02:00
fn bool_ret6(x: bool, y: bool) -> bool {
2018-12-09 23:26:16 +01:00
if x && y {
return false;
} else {
return true;
};
}
fn needless_bool(x: bool) {
2018-12-09 23:26:16 +01:00
if x == true {};
}
fn needless_bool2(x: bool) {
2018-12-09 23:26:16 +01:00
if x == false {};
}
fn needless_bool3(x: bool) {
bool_comparison_trigger! {
test_one: false, false;
test_three: false, false;
test_two: true, true;
}
2018-12-09 23:26:16 +01:00
if x == true {};
if x == false {};
}