rust/tests/ui/useless_asref.rs

137 lines
2.9 KiB
Rust
Raw Normal View History

// run-rustfix
2018-07-28 17:34:52 +02:00
#![deny(clippy::useless_asref)]
#![allow(clippy::trivially_copy_pass_by_ref)]
2017-10-21 19:42:35 +02:00
use std::fmt::Debug;
2017-10-20 17:39:20 +02:00
struct FakeAsRef;
2018-07-28 17:34:52 +02:00
#[allow(clippy::should_implement_trait)]
2017-10-20 17:39:20 +02:00
impl FakeAsRef {
2018-12-09 23:26:16 +01:00
fn as_ref(&self) -> &Self {
self
}
2017-10-20 17:39:20 +02:00
}
struct MoreRef;
impl<'a, 'b, 'c> AsRef<&'a &'b &'c MoreRef> for MoreRef {
fn as_ref(&self) -> &&'a &'b &'c MoreRef {
&&&&MoreRef
}
}
2018-12-09 23:26:16 +01:00
fn foo_rstr(x: &str) {
println!("{:?}", x);
}
fn foo_rslice(x: &[i32]) {
println!("{:?}", x);
}
fn foo_mrslice(x: &mut [i32]) {
println!("{:?}", x);
}
fn foo_rrrrmr(_: &&&&MoreRef) {
println!("so many refs");
}
2017-10-20 17:39:20 +02:00
fn not_ok() {
let rstr: &str = "hello";
2018-12-09 23:26:16 +01:00
let mut mrslice: &mut [i32] = &mut [1, 2, 3];
2017-10-20 17:39:20 +02:00
{
let rslice: &[i32] = &*mrslice;
foo_rstr(rstr.as_ref());
foo_rstr(rstr);
foo_rslice(rslice.as_ref());
foo_rslice(rslice);
}
{
foo_mrslice(mrslice.as_mut());
foo_mrslice(mrslice);
foo_rslice(mrslice.as_ref());
foo_rslice(mrslice);
}
{
let rrrrrstr = &&&&rstr;
let rrrrrslice = &&&&&*mrslice;
foo_rslice(rrrrrslice.as_ref());
foo_rslice(rrrrrslice);
foo_rstr(rrrrrstr.as_ref());
foo_rstr(rrrrrstr);
}
{
let mrrrrrslice = &mut &mut &mut &mut mrslice;
foo_mrslice(mrrrrrslice.as_mut());
foo_mrslice(mrrrrrslice);
foo_rslice(mrrrrrslice.as_ref());
foo_rslice(mrrrrrslice);
}
#[allow(unused_parens, clippy::double_parens)]
2017-10-20 17:39:20 +02:00
foo_rrrrmr((&&&&MoreRef).as_ref());
2017-10-21 19:42:35 +02:00
generic_not_ok(mrslice);
generic_ok(mrslice);
2017-10-20 17:39:20 +02:00
}
fn ok() {
let string = "hello".to_owned();
2018-12-09 23:26:16 +01:00
let mut arr = [1, 2, 3];
let mut vec = vec![1, 2, 3];
2017-10-20 17:39:20 +02:00
{
foo_rstr(string.as_ref());
foo_rslice(arr.as_ref());
foo_rslice(vec.as_ref());
}
{
foo_mrslice(arr.as_mut());
foo_mrslice(vec.as_mut());
}
{
let rrrrstring = &&&&string;
let rrrrarr = &&&&arr;
let rrrrvec = &&&&vec;
foo_rstr(rrrrstring.as_ref());
foo_rslice(rrrrarr.as_ref());
foo_rslice(rrrrvec.as_ref());
}
{
let mrrrrarr = &mut &mut &mut &mut arr;
let mrrrrvec = &mut &mut &mut &mut vec;
foo_mrslice(mrrrrarr.as_mut());
foo_mrslice(mrrrrvec.as_mut());
}
FakeAsRef.as_ref();
foo_rrrrmr(MoreRef.as_ref());
2017-10-21 19:42:35 +02:00
generic_not_ok(arr.as_mut());
generic_ok(&mut arr);
2017-10-20 17:39:20 +02:00
}
2017-10-21 19:42:35 +02:00
2018-12-09 23:26:16 +01:00
fn foo_mrt<T: Debug + ?Sized>(t: &mut T) {
println!("{:?}", t);
}
fn foo_rt<T: Debug + ?Sized>(t: &T) {
println!("{:?}", t);
}
2017-10-21 19:42:35 +02:00
fn generic_not_ok<T: AsMut<T> + AsRef<T> + Debug + ?Sized>(mrt: &mut T) {
foo_mrt(mrt.as_mut());
foo_mrt(mrt);
foo_rt(mrt.as_ref());
foo_rt(mrt);
}
fn generic_ok<U: AsMut<T> + AsRef<T> + ?Sized, T: Debug + ?Sized>(mru: &mut U) {
foo_mrt(mru.as_mut());
foo_rt(mru.as_ref());
}
2017-10-20 17:39:20 +02:00
fn main() {
not_ok();
ok();
}