rust/README.md

167 lines
6.5 KiB
Markdown
Raw Normal View History

We are currently in the process of discussing Clippy 1.0 via the RFC process in https://github.com/rust-lang/rfcs/pull/2476 . The RFC's goal is to clarify policies around lint categorizations and the policy around which lints should be in the compiler and which lints should be in Clippy. Please leave your thoughts on the RFC PR.
2018-06-20 20:37:22 +02:00
# Clippy
2016-05-06 16:07:47 +02:00
[![Build Status](https://travis-ci.org/rust-lang-nursery/rust-clippy.svg?branch=master)](https://travis-ci.org/rust-lang-nursery/rust-clippy)
[![Windows Build status](https://ci.appveyor.com/api/projects/status/id677xpw1dguo7iw?svg=true)](https://ci.appveyor.com/project/rust-lang-libs/rust-clippy)
[![Current Version](https://meritbadge.herokuapp.com/clippy)](https://crates.io/crates/clippy)
[![License: MIT/Apache-2.0](https://img.shields.io/crates/l/clippy.svg)](#license)
2014-11-19 08:50:46 +01:00
A collection of lints to catch common mistakes and improve your [Rust](https://github.com/rust-lang/rust) code.
2014-11-19 20:19:03 +01:00
2018-09-27 19:10:20 +02:00
[There are 280 lints included in this crate!](https://rust-lang-nursery.github.io/rust-clippy/master/index.html)
We have a bunch of lint categories to allow you to choose how much Clippy is supposed to ~~annoy~~ help you:
2018-03-29 13:04:52 +02:00
2018-07-28 17:35:24 +02:00
* `clippy::all` (everything that has no false positives)
* `clippy::pedantic` (everything)
* `clippy::nursery` (new lints that aren't quite ready yet)
* `clippy::style` (code that should be written in a more idiomatic way)
* `clippy::complexity` (code that does something simple but in a complex way)
* `clippy::perf` (code that can be written in a faster way)
* `clippy::cargo` (checks against the cargo manifest)
* **`clippy::correctness`** (code that is just outright wrong or very very useless)
2018-03-29 13:04:52 +02:00
More to come, please [file an issue](https://github.com/rust-lang-nursery/rust-clippy/issues) if you have ideas!
Only the following of those categories are enabled by default:
* `clippy::style`
* `clippy::correctness`
* `clippy::complexity`
* `clippy::perf`
Other categories need to be enabled in order for their lints to be executed.
2016-02-22 15:50:40 +01:00
Table of contents:
2016-03-10 21:42:24 +01:00
2016-05-06 16:07:47 +02:00
* [Usage instructions](#usage)
* [Configuration](#configuration)
* [License](#license)
2016-09-15 17:19:30 +02:00
## Usage
Since this is a tool for helping the developer of a library or application
write better code, it is recommended not to include Clippy as a hard dependency.
Options include using it as an optional dependency, as a cargo subcommand, or
as an included feature during build. These options are detailed below.
### As a cargo subcommand (`cargo clippy`)
2016-09-15 17:19:30 +02:00
One way to use Clippy is by installing Clippy through rustup as a cargo
subcommand.
#### Step 1: Install rustup
You can install [rustup](http://rustup.rs/) on supported platforms. This will help
us install Clippy and its dependencies.
If you already have rustup installed, update to ensure you have the latest
rustup and compiler:
```terminal
rustup update
```
#### Step 2: Install Clippy
2018-01-12 11:33:13 +01:00
Once you have rustup and the latest stable release (at least Rust 1.29) installed, run the following command:
```terminal
rustup component add clippy-preview
```
Now you can run Clippy by invoking `cargo clippy`.
If it says that it can't find the `clippy` subcommand, please run `rustup self update`
### Running Clippy from the command line without installing it
2016-09-15 17:19:30 +02:00
To have cargo compile your crate with Clippy without Clippy installation
2016-09-15 17:19:30 +02:00
in your code, you can use:
```terminal
cargo run --bin cargo-clippy --manifest-path=path_to_clippys_Cargo.toml
2016-09-15 17:19:30 +02:00
```
*[Note](https://github.com/rust-lang-nursery/rust-clippy/wiki#a-word-of-warning):*
Be sure that Clippy was compiled with the same version of rustc that cargo invokes here!
2016-09-15 17:19:30 +02:00
2018-09-14 08:21:14 +02:00
### Travis CI
You can add Clippy to Travis CI in the same way you use it locally:
```yml
2018-09-25 15:40:17 +02:00
language: rust
rust:
- stable
- beta
before_script:
- rustup component add clippy-preview
script:
- cargo clippy
# if you want the build job to fail when encountering warnings, use
- cargo clippy -- -D warnings
# in order to also check tests and none-default crate features, use
- cargo clippy --all-targets --all-features -- -D warnings
- cargo test
# etc.
2018-09-14 08:21:14 +02:00
```
2016-09-15 17:19:30 +02:00
## Configuration
Some lints can be configured in a TOML file named `clippy.toml` or `.clippy.toml`. It contains a basic `variable = value` mapping eg.
2016-09-15 17:19:30 +02:00
```toml
blacklisted-names = ["toto", "tata", "titi"]
cyclomatic-complexity-threshold = 30
```
See the [list of lints](https://rust-lang-nursery.github.io/rust-clippy/master/index.html) for more information about which lints can be configured and the
2016-09-15 17:19:30 +02:00
meaning of the variables.
To deactivate the “for further information visit *lint-link*” message you can
2017-09-01 10:29:49 +02:00
define the `CLIPPY_DISABLE_DOCS_LINKS` environment variable.
2016-09-15 17:19:30 +02:00
### Allowing/denying lints
You can add options to your code to `allow`/`warn`/`deny` Clippy lints:
2016-09-15 17:19:30 +02:00
2018-07-28 17:35:24 +02:00
* the whole set of `Warn` lints using the `clippy` lint group (`#![deny(clippy::all)]`)
2016-09-15 17:19:30 +02:00
2018-07-28 17:35:24 +02:00
* all lints using both the `clippy` and `clippy::pedantic` lint groups (`#![deny(clippy::all)]`,
`#![deny(clippy::pedantic)]`). Note that `clippy::pedantic` contains some very aggressive
2016-09-15 17:19:30 +02:00
lints prone to false positives.
2018-07-28 17:35:24 +02:00
* only some lints (`#![deny(clippy::single_match, clippy::box_vec)]`, etc)
2016-09-15 17:19:30 +02:00
* `allow`/`warn`/`deny` can be limited to a single function or module using `#[allow(...)]`, etc
Note: `deny` produces errors instead of warnings.
2018-10-11 12:16:22 +02:00
Note: To use the new `clippy::lint_name` syntax, a recent compiler has to be used
currently. If you want to compile your code with the stable toolchain you can use a `cfg_attr` to
activate the `tool_lints` feature:
```rust
#![cfg_attr(feature = "cargo-clippy", allow(clippy::lint_name))]
```
2018-10-11 12:16:22 +02:00
For this to work you have to use Clippy on the nightly toolchain: `cargo +nightly clippy`. If you
want to use Clippy with the stable toolchain, you can stick to the old unscoped method to
enable/disable Clippy lints until `tool_lints` are stable:
```rust
#![cfg_attr(feature = "cargo-clippy", allow(clippy_lint))]
```
2018-10-02 10:39:51 +02:00
If you do not want to include your lint levels in your code, you can globally enable/disable lints by passing extra flags to clippy during the run: `cargo clippy -- -A lint_name` will run clippy with `lint_name` disabled and `cargo clippy -- -W lint_name` will run it with that enabled. On newer compilers you may need to use `clippy::lint_name` instead.
2016-05-06 16:07:47 +02:00
## License
2018-10-07 04:29:01 +02:00
Copyright 2014-2018 The Rust Project Developers
Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
<LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
option. All files in the project carrying such notice may not be
copied, modified, or distributed except according to those terms.