rust/tests/ui/bit_masks.rs

64 lines
1.6 KiB
Rust
Raw Normal View History

2018-12-09 23:26:16 +01:00
const THREE_BITS: i64 = 7;
const EVEN_MORE_REDIRECTION: i64 = THREE_BITS;
2018-07-28 17:34:52 +02:00
#[warn(clippy::bad_bit_mask)]
2018-12-09 23:26:16 +01:00
#[allow(
clippy::ineffective_bit_mask,
clippy::identity_op,
clippy::no_effect,
clippy::unnecessary_operation
)]
fn main() {
let x = 5;
2017-02-08 14:58:07 +01:00
x & 0 == 0;
x & 1 == 1; //ok, distinguishes bit 0
x & 1 == 0; //ok, compared with zero
2017-02-08 14:58:07 +01:00
x & 2 == 1;
x | 0 == 0; //ok, equals x == 0 (maybe warn?)
x | 1 == 3; //ok, equals x == 2 || x == 3
x | 3 == 3; //ok, equals x <= 3
2017-02-08 14:58:07 +01:00
x | 3 == 2;
2017-02-08 14:58:07 +01:00
x & 1 > 1;
x & 2 > 1; // ok, distinguishes x & 2 == 2 from x & 2 == 0
x & 2 < 1; // ok, distinguishes x & 2 == 2 from x & 2 == 0
x | 1 > 1; // ok (if a bit silly), equals x > 1
2017-02-08 14:58:07 +01:00
x | 2 > 1;
x | 2 <= 2; // ok (if a bit silly), equals x <= 2
2015-09-06 16:09:35 +02:00
x & 192 == 128; // ok, tests for bit 7 and not bit 6
x & 0xffc0 == 0xfe80; // ok
2015-09-28 07:11:03 +02:00
// this also now works with constants
2017-02-08 14:58:07 +01:00
x & THREE_BITS == 8;
x | EVEN_MORE_REDIRECTION < 7;
2017-02-08 14:58:07 +01:00
0 & x == 0;
1 | x > 1;
// and should now also match uncommon usage
2017-02-08 14:58:07 +01:00
1 < 2 | x;
2 == 3 | x;
1 == x & 2;
x | 1 > 2; // no error, because we allowed ineffective bit masks
ineffective();
2015-05-15 14:09:29 +02:00
}
2018-07-28 17:34:52 +02:00
#[warn(clippy::ineffective_bit_mask)]
#[allow(clippy::bad_bit_mask, clippy::no_effect, clippy::unnecessary_operation)]
2015-05-15 14:09:29 +02:00
fn ineffective() {
let x = 5;
2017-02-08 14:58:07 +01:00
x | 1 > 3;
x | 1 < 4;
x | 1 <= 3;
x | 1 >= 8;
2015-08-19 09:07:50 +02:00
x | 1 > 2; // not an error (yet), better written as x >= 2
x | 1 >= 7; // not an error (yet), better written as x >= 6
x | 3 > 4; // not an error (yet), better written as x >= 4
x | 4 <= 19;
}