squiid/mlibc
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

options/posix: Properly implement setsid()

Browse source
This commit is contained in:
Alexander van der Grinten 2020-05-16 18:19:27 +02:00
parent 8351847c20
commit 3a56039e65
3 changed files with 48 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
options/internal/include/mlibc/sysdeps.hpp
View file

@ -145,6 +145,7 @@ int sys_vm_unmap(void *pointer, size_t size);
[[gnu::weak]] int sys_vm_readahead(void *pointer, size_t size);
#ifndef MLIBC_BUILDING_RTDL
[[gnu::weak]] int sys_setsid(pid_t *sid);
[[gnu::weak]] int sys_tcgetattr(int fd, struct termios *attr);
[[gnu::weak]] int sys_tcsetattr(int, int, const struct termios *attr);
[[gnu::weak]] int sys_tcflow(int, int);

12
options/posix/generic/unistd-stubs.cpp
View file

@ -511,8 +511,16 @@ int setreuid(uid_t, uid_t) {
__builtin_unreachable();
}
pid_t setsid(void) {
mlibc::infoLogger() << "\e[31mmlibc: setsid() is a no-op\e[39m" << frg::endlog;
return 1;
if(!mlibc::sys_setsid) {
MLIBC_MISSING_SYSDEP();
return -1;
}
pid_t sid;
if(int e = mlibc::sys_setsid(&sid); e) {
errno = e;
return -1;
}
return sid;
}
int setuid(uid_t uid) {

37
sysdeps/managarm/generic/file.cpp
View file

@ -877,6 +877,43 @@ int sys_vm_unmap(void *pointer, size_t size) {
return 0;
}
int sys_setsid(pid_t *sid) {
SignalGuard sguard;
HelAction actions[3];
globalQueue.trim();
managarm::posix::CntRequest<MemoryAllocator> req(getSysdepsAllocator());
req.set_request_type(managarm::posix::CntReqType::SETSID);
frg::string<MemoryAllocator> ser(getSysdepsAllocator());
req.SerializeToString(&ser);
actions[0].type = kHelActionOffer;
actions[0].flags = kHelItemAncillary;
actions[1].type = kHelActionSendFromBuffer;
actions[1].flags = kHelItemChain;
actions[1].buffer = ser.data();
actions[1].length = ser.size();
actions[2].type = kHelActionRecvInline;
actions[2].flags = 0;
HEL_CHECK(helSubmitAsync(getPosixLane(), actions, 3,
globalQueue.getQueue(), 0, 0));
auto element = globalQueue.dequeueSingle();
auto offer = parseSimple(element);
auto send_req = parseSimple(element);
auto recv_resp = parseInline(element);
HEL_CHECK(offer->error);
HEL_CHECK(send_req->error);
HEL_CHECK(recv_resp->error);
managarm::posix::SvrResponse<MemoryAllocator> resp(getSysdepsAllocator());
resp.ParseFromArray(recv_resp->data, recv_resp->length);
__ensure(resp.error() == managarm::posix::Errors::SUCCESS);
*sid = resp.sid();
return 0;
}
int sys_tcgetattr(int fd, struct termios *attr) {
int result;
if(int e = sys_ioctl(fd, TCGETS, attr, &result); e)