9dd2d50984
The previous code used an unbounded sprintf, which in theory can overflow, writing either the null terminator or the last digits into the next struct member. In practice, in LLD, all long section names are written sequentially first at the start of the string table, followed by all the long symbol names. Due to this, even if the total string table would end up large, the long section names have fairly short offsets, which is why this hasn't been an issue in practice. I don't think it's worth trying to write a test that produces an executable with enough long section names to make the section names themselves exceed 10^6 bytes, which is currently necessary to trigger faults with the previous form. Differential Revision: https://reviews.llvm.org/D120676 |
||
|---|---|---|
| .. | ||
| CallGraphSort.cpp | ||
| CallGraphSort.h | ||
| Chunks.cpp | ||
| Chunks.h | ||
| CMakeLists.txt | ||
| COFFLinkerContext.cpp | ||
| COFFLinkerContext.h | ||
| Config.h | ||
| DebugTypes.cpp | ||
| DebugTypes.h | ||
| DLL.cpp | ||
| DLL.h | ||
| Driver.cpp | ||
| Driver.h | ||
| DriverUtils.cpp | ||
| ICF.cpp | ||
| ICF.h | ||
| InputFiles.cpp | ||
| InputFiles.h | ||
| LLDMapFile.cpp | ||
| LLDMapFile.h | ||
| LTO.cpp | ||
| LTO.h | ||
| MapFile.cpp | ||
| MapFile.h | ||
| MarkLive.cpp | ||
| MarkLive.h | ||
| MinGW.cpp | ||
| MinGW.h | ||
| Options.td | ||
| PDB.cpp | ||
| PDB.h | ||
| README.md | ||
| Symbols.cpp | ||
| Symbols.h | ||
| SymbolTable.cpp | ||
| SymbolTable.h | ||
| TypeMerger.h | ||
| Writer.cpp | ||
| Writer.h | ||
See docs/NewLLD.rst