Find a file
Matt Arsenault 42098c4a30 GlobalISel: Fix legalization error where CSE leaves behind dead defs
If the conversion artifact introduced in the unmerge of cast of merge
combine already existed in the function, this would introduce dead
copies which kept the old casts around, neither of which were deleted,
and would fail legalization.

This would fail as follows:

The G_UNMERGE_VALUES of the G_SEXT of the G_BUILD_VECTOR would
introduce a G_SEXT for each of the scalars.

Some of the required G_SEXTs already existed in the function, so CSE
moves them up in the function and introduces a copy to the original
result register.

The introduced CSE copies are dead, since the originally G_SEXTs were
already directly used. These copies add a use to the illegal G_SEXTs,
so they are not deleted.

The artifact combiner does not see the defs that need to be updated,
since it was hidden inside the CSE builder.

I see 2 potential fixes, and opted for the mechanically simpler one,
which is to just not insert the cast if the result operand isn't
used. Alternatively, we could not insert the cast directly into the
result register, and use replaceRegOrBuildCopy similar to the case
where there is no conversion.

I suspect this is a wider problem in the artifact combiner.
2022-01-18 17:04:40 -05:00
.github workflows: Make issue-subscriber more robust for labels with special characters 2022-01-14 22:04:54 -08:00
bolt [BOLT][NFC] Delimit bytes in MCAnnotation bitmask 2022-01-18 13:25:45 -08:00
clang [clang][dataflow] Add a test to justify skipping past references in UO_Deref 2022-01-18 21:27:43 +00:00
clang-tools-extra [clang-tidy] Make readability-container-data-pointer more robust 2022-01-18 21:08:59 +01:00
cmake [doc][cmake] Convert read-me for the common CMake utils to reST 2022-01-10 21:36:11 +00:00
compiler-rt [compiler-rt][cmake] Use GNUInstallDirs to support custom installation dirs 2022-01-17 03:13:56 +00:00
cross-project-tests [mlir] Finish removing Identifier from the C++ API 2022-01-12 11:58:23 -08:00
flang [flang] Support substring references in NAMELIST input 2022-01-18 11:24:17 -08:00
libc Revert "[cmake] Use GNUInstallDirs to support custom installation dirs." 2022-01-16 05:48:30 +00:00
libclc libclc: Add clspv64 target 2022-01-13 09:28:19 +00:00
libcxx [libcxx][test] unordered_meow iterators are not portably non-bidi 2022-01-18 11:43:21 -08:00
libcxxabi [libcxx][libcxxabi][libunwind][cmake] Use GNUInstallDirs to support custom installation dirs 2022-01-18 06:44:57 +00:00
libunwind [libcxx][libcxxabi][libunwind][cmake] Use GNUInstallDirs to support custom installation dirs 2022-01-18 06:44:57 +00:00
lld [lld][WebAssembly] Reinstate mistakenly disabled test. NFC 2022-01-18 12:22:22 -08:00
lldb [lldb] Delete TestStopReplyContainsThreadPcs 2022-01-18 14:17:33 +01:00
llvm GlobalISel: Fix legalization error where CSE leaves behind dead defs 2022-01-18 17:04:40 -05:00
mlir Allows deferred location attribute in parseOptionalLocationSpecifier 2022-01-18 22:00:36 +00:00
openmp Revert "[Libomptarget] Fix external visibility for internal variables" 2022-01-18 14:44:11 -05:00
polly [polly][cmake] Use GNUInstallDirs to support custom installation dirs 2022-01-18 20:33:42 +00:00
pstl [pstl][cmake] Use GNUInstallDirs to support custom installation dirs 2022-01-17 20:04:46 +00:00
runtimes [CMake] Use LLVM_COMMON_CMAKE_UTILS in runtimes just for clarity 2022-01-03 20:55:44 +00:00
third-party Ensure newlines at the end of files (NFC) 2021-12-26 08:51:06 -08:00
utils [mlir] Replace StrEnumAttr -> EnumAttr in core dialects 2022-01-18 17:15:00 +00:00
.arcconfig
.arclint
.clang-format
.clang-tidy Add IgnoreBaseInCopyConstructors to .clang-tidy 2022-01-03 13:41:32 -08:00
.git-blame-ignore-revs
.gitignore
.mailmap
CONTRIBUTING.md docs: update some bug tracker references (NFC) 2022-01-10 15:59:08 -08:00
README.md
SECURITY.md

The LLVM Compiler Infrastructure

This directory and its sub-directories contain source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.

The README briefly describes how to get started with building LLVM. For more information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.

Getting Started with the LLVM System

Taken from https://llvm.org/docs/GettingStarted.html.

Overview

Welcome to the LLVM project!

The LLVM project has multiple components. The core of the project is itself called "LLVM". This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer. It also contains basic regression tests.

C-like languages use the Clang front end. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.

Other components include: the libc++ C++ standard library, the LLD linker, and more.

Getting the Source Code and Building LLVM

The LLVM Getting Started documentation may be out of date. The Clang Getting Started page might have more accurate information.

This is an example work-flow and configuration to get and build the LLVM source:

  1. Checkout LLVM (including related sub-projects like Clang):

    • git clone https://github.com/llvm/llvm-project.git

    • Or, on windows, git clone --config core.autocrlf=false https://github.com/llvm/llvm-project.git

  2. Configure and build LLVM and Clang:

    • cd llvm-project

    • cmake -S llvm -B build -G <generator> [options]

      Some common build system generators are:

      • Ninja --- for generating Ninja build files. Most llvm developers use Ninja.
      • Unix Makefiles --- for generating make-compatible parallel makefiles.
      • Visual Studio --- for generating Visual Studio projects and solutions.
      • Xcode --- for generating Xcode projects.

      Some common options:

      • -DLLVM_ENABLE_PROJECTS='...' --- semicolon-separated list of the LLVM sub-projects you'd like to additionally build. Can include any of: clang, clang-tools-extra, compiler-rt,cross-project-tests, flang, libc, libclc, libcxx, libcxxabi, libunwind, lld, lldb, mlir, openmp, polly, or pstl.

        For example, to build LLVM, Clang, libcxx, and libcxxabi, use -DLLVM_ENABLE_PROJECTS="clang;libcxx;libcxxabi".

      • -DCMAKE_INSTALL_PREFIX=directory --- Specify for directory the full path name of where you want the LLVM tools and libraries to be installed (default /usr/local).

      • -DCMAKE_BUILD_TYPE=type --- Valid options for type are Debug, Release, RelWithDebInfo, and MinSizeRel. Default is Debug.

      • -DLLVM_ENABLE_ASSERTIONS=On --- Compile with assertion checks enabled (default is Yes for Debug builds, No for all other build types).

    • cmake --build build [-- [options] <target>] or your build system specified above directly.

      • The default target (i.e. ninja or make) will build all of LLVM.

      • The check-all target (i.e. ninja check-all) will run the regression tests to ensure everything is in working order.

      • CMake will generate targets for each tool and library, and most LLVM sub-projects generate their own check-<project> target.

      • Running a serial build will be slow. To improve speed, try running a parallel build. That's done by default in Ninja; for make, use the option -j NNN, where NNN is the number of parallel jobs, e.g. the number of CPUs you have.

    • For more information see CMake

Consult the Getting Started with LLVM page for detailed information on configuring and compiling LLVM. You can visit Directory Layout to learn about the layout of the source code tree.