llvm/lld/test
Fangrui Song dccd061302 [ELF] Suppress "duplicate symbol" when resolving STB_WEAK and STB_GNU_UNIQUE in different COMDATs
```
template <typename T> struct A {
  A() {}
  int value = 0;
};

template <typename Value> struct B {
  static A<int> a;
};

template <typename Value> A<int> B<Value>::a;

inline int foo() {
  return B<int>::a.value;
}
```

```
clang++ -c -fno-pic a.cc -o weak.o
g++ -c -fno-pic a.cc -o unique.o  # --enable-gnu-unique-object

# Duplicate symbol error. In postParse, we do not check `sym.binding`
ld.lld -e 0 weak.o unique.o
```

Mixing GCC and Clang object files in this case is not ideal. .bss._ZGVN1BIiE1aE
has different COMDAT groups. It appears to work in practice because the guard
variable prevents harm due to double initialization.

For the linker, we just stick with the rule that a weak binding does not cause
"duplicate symbol" errors.

Close https://github.com/llvm/llvm-project/issues/58232

Differential Revision: https://reviews.llvm.org/D136381

(cherry picked from commit 0051b6bb78772b0658f28e5f31ddf91c1589aab5)
2022-10-24 13:49:35 +02:00
..
COFF [LLD][COFF] Fix writing a map file when range extension thunks are inserted 2022-09-12 12:54:42 +02:00
ELF [ELF] Suppress "duplicate symbol" when resolving STB_WEAK and STB_GNU_UNIQUE in different COMDATs 2022-10-24 13:49:35 +02:00
MachO [MachO] Don't fold compact unwind entries with LSDA 2022-09-14 08:14:57 +02:00
MinGW [LLD] [MinGW] Implement the --exclude-symbols option 2022-08-12 08:36:08 +02:00
wasm
CMakeLists.txt [BUILD] Add missed CMakeLists.txt change from dfb77f2 2022-07-05 16:04:58 +01:00
lit.cfg.py [LLD][ELF] Add FORCE_LLD_DIAGNOSTICS_CRASH to force LLD to crash 2022-07-05 09:43:09 +01:00
lit.site.cfg.py.in Revert "[llvm] cmake config groundwork to have ZSTD in LLVM" 2022-07-08 13:48:05 -07:00