squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

Re-land [MC] Fix quadratic behavior in addPendingLabel

Browse source 
This was discovered when compiling large unity/blob/jumbo files.

Differential Revision: https://reviews.llvm.org/D78775
This commit is contained in:
Alexandre Ganea 2020-04-26 10:39:30 -04:00
parent acbc5ede99
commit fd773e8a51
2 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
llvm/include/llvm/MC/MCObjectStreamer.h
View file

@ -9,6 +9,7 @@
#ifndef LLVM_MC_MCOBJECTSTREAMER_H
#define LLVM_MC_MCOBJECTSTREAMER_H
#include "llvm/ADT/SetVector.h"
#include "llvm/ADT/SmallVector.h"
#include "llvm/MC/MCAssembler.h"
#include "llvm/MC/MCSection.h"
@ -38,7 +39,7 @@ class MCObjectStreamer : public MCStreamer {
bool EmitEHFrame;
bool EmitDebugFrame;
SmallVector<MCSymbol *, 2> PendingLabels;
SmallVector<MCSection*, 2> PendingLabelSections;
SmallSetVector<MCSection *, 4> PendingLabelSections;
unsigned CurSubsectionIdx;
struct PendingMCFixup {
const MCSymbol *Sym;

8
llvm/lib/MC/MCObjectStreamer.cpp
View file

@ -59,12 +59,8 @@ void MCObjectStreamer::addPendingLabel(MCSymbol* S) {
CurSection->addPendingLabel(S, CurSubsectionIdx);
// Add this Section to the list of PendingLabelSections.
auto SecIt = std::find(PendingLabelSections.begin(),
PendingLabelSections.end(), CurSection);
if (SecIt == PendingLabelSections.end())
PendingLabelSections.push_back(CurSection);
}
else
PendingLabelSections.insert(CurSection);
} else
// There is no Section / Subsection for this label yet.
PendingLabels.push_back(S);
}