squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

[clang-tidy] Ignore variable template partial specializations in misc-definitions-in-headers

Browse source 
Variable template partial specializations are inline and can't lead
to ODR-violations. The checker now ignores them.

Fixes https://github.com/llvm/llvm-project/issues/53519

Reviewed By: hokein

Differential Revision: https://reviews.llvm.org/D119098
This commit is contained in:
Evgeny Shulgin 2022-02-14 11:28:22 +01:00 committed by Haojian Wu
parent 7dd7ccd224
commit fc84ebfff3
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp
View file

@ -149,6 +149,9 @@ void DefinitionsInHeadersCheck::check(const MatchFinder::MatchResult &Result) {
// Ignore inline variables.
if (VD->isInline())
return;
// Ignore partial specializations.
if (isa<VarTemplatePartialSpecializationDecl>(VD))
return;
diag(VD->getLocation(),
"variable %0 defined in a header file; "

10
clang-tools-extra/test/clang-tidy/checkers/misc-definitions-in-headers.hpp
View file

@ -193,6 +193,16 @@ const int f12() { return 0; }
// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: full function template specialization 'f12<int>' defined in a header file;
// CHECK-FIXES: inline const int f12() { return 0; }
template <typename T1, typename T2>
constexpr bool f13 = false;
template <typename T>
constexpr bool f13<T, int> = true; // OK: template partial specialization
template <>
constexpr bool f13<void, int> = false;
// CHECK-MESSAGES: :[[@LINE-1]]:16: warning: variable 'f13<void, int>' defined in a header file;
int main() {}
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: function 'main' defined in a header file;
// CHECK-FIXES: {{^}}int main() {