squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

[AST] Avoid single-trip loop in ClangAttrEmitter

Browse source 
This triggers coverity warnings, see https://reviews.llvm.org/D107703
This commit is contained in:
Sam McCall 2021-08-20 08:49:25 +02:00
parent fd21d1e198
commit eabb1f0732
1 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
clang/utils/TableGen/ClangAttrEmitter.cpp
View file

@ -4235,15 +4235,13 @@ void EmitClangAttrDocTable(RecordKeeper &Records, raw_ostream &OS) {
if (!A->getValueAsBit("ASTNode"))
continue;
std::vector<Record *> Docs = A->getValueAsListOfDefs("Documentation");
for (const auto *D : Docs) {
OS << "\nstatic const char AttrDoc_" << A->getName() << "[] = "
<< "R\"reST("
<< D->getValueAsOptionalString("Content").getValueOr("").trim()
<< ")reST\";\n";
// Only look at the first documentation if there are several.
// (Currently there's only one such attr, revisit if this becomes common).
break;
}
assert(!Docs.empty());
// Only look at the first documentation if there are several.
// (Currently there's only one such attr, revisit if this becomes common).
StringRef Text =
Docs.front()->getValueAsOptionalString("Content").getValueOr("");
OS << "\nstatic const char AttrDoc_" << A->getName() << "[] = "
<< "R\"reST(" << Text.trim() << ")reST\";\n";
}
}