squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

[clangd, llvm] Remove redundant calls to c_str() (NFC)

Browse source 
Identified with readability-redundant-string-cstr.
This commit is contained in:
Kazu Hirata 2021-09-02 09:07:13 -07:00
parent 123f811fe5
commit e1bb54b593
6 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
clang-tools-extra/clangd/PathMapping.cpp
View file

@ -40,7 +40,7 @@ llvm::Optional<std::string> doPathMapping(llvm::StringRef S,
llvm::StringRef Body = Uri->body();
if (Body.consume_front(From) && (Body.empty() || Body.front() == '/')) {
std::string MappedBody = (To + Body).str();
return URI(Uri->scheme(), Uri->authority(), MappedBody.c_str())
return URI(Uri->scheme(), Uri->authority(), MappedBody)
.toString();
}
}

2
llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXTargetStreamer.cpp
View file

@ -26,7 +26,7 @@ NVPTXTargetStreamer::~NVPTXTargetStreamer() = default;
void NVPTXTargetStreamer::outputDwarfFileDirectives() {
for (const std::string &S : DwarfFiles)
getStreamer().emitRawText(S.data());
getStreamer().emitRawText(S);
DwarfFiles.clear();
}

4
llvm/tools/bugpoint/OptimizerDriver.cpp
View file

@ -223,8 +223,8 @@ bool BugDriver::runPasses(Module &Program,
for (std::vector<std::string>::const_iterator I = pass_args.begin(),
E = pass_args.end();
I != E; ++I)
Args.push_back(I->c_str());
Args.push_back(Temp->TmpName.c_str());
Args.push_back(*I);
Args.push_back(Temp->TmpName);
Args.append(ExtraArgs.begin(), ExtraArgs.end());
LLVM_DEBUG(errs() << "\nAbout to run:\t";

4
llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
View file

@ -337,7 +337,7 @@ static llvm::Error handleObjectFile(ObjectFile &Obj,
// Save the GSYM file to disk.
support::endianness Endian =
Obj.makeTriple().isLittleEndian() ? support::little : support::big;
if (auto Err = Gsym.save(OutFile.c_str(), Endian))
if (auto Err = Gsym.save(OutFile, Endian))
return Err;
// Verify the DWARF if requested. This will ensure all the info in the DWARF
@ -359,7 +359,7 @@ static llvm::Error handleBuffer(StringRef Filename, MemoryBufferRef Buffer,
Triple ObjTriple(Obj->makeTriple());
auto ArchName = ObjTriple.getArchName();
outs() << "Output file (" << ArchName << "): " << OutFile << "\n";
if (auto Err = handleObjectFile(*Obj, OutFile.c_str()))
if (auto Err = handleObjectFile(*Obj, OutFile))
return Err;
} else if (auto *Fat = dyn_cast<MachOUniversalBinary>(BinOrErr->get())) {
// Iterate over all contained architectures and filter out any that were

2
llvm/tools/llvm-lto/llvm-lto.cpp
View file

@ -1059,7 +1059,7 @@ int main(int argc, char **argv) {
CodeGen.addMustPreserveSymbol(KeptDSOSyms[i]);
// Set cpu and attrs strings for the default target/subtarget.
CodeGen.setCpu(codegen::getMCPU().c_str());
CodeGen.setCpu(codegen::getMCPU());
CodeGen.setOptLevel(OptLevel - '0');
CodeGen.setAttrs(codegen::getMAttrs());

2
llvm/tools/llvm-readobj/ELFDumper.cpp
View file

@ -4362,7 +4362,7 @@ template <class ELFT> void GNUELFDumper<ELFT>::printDynamicTable() {
for (auto Entry : Table) {
uintX_t Tag = Entry.getTag();
std::string Type =
std::string("(") + this->Obj.getDynamicTagAsString(Tag).c_str() + ")";
std::string("(") + this->Obj.getDynamicTagAsString(Tag) + ")";
std::string Value = this->getDynamicEntry(Tag, Entry.getVal());
OS << " " << format_hex(Tag, ELFT::Is64Bits ? 18 : 10)
<< format(ValueFmt.c_str(), Type.c_str()) << Value << "\n";