squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

[clang][Checkers] Extend PthreadLockChecker state dump (NFC).

Browse source 
Add printing of map 'DestroyRetVal'.

Reviewed By: steakhal

Differential Revision: https://reviews.llvm.org/D98502
This commit is contained in:
Balázs Kéri 2021-04-01 11:10:07 +02:00
parent e3a13304fc
commit df4fa53fdd
3 changed files with 92 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp
View file

@ -339,7 +339,16 @@ void PthreadLockChecker::printState(raw_ostream &Out, ProgramStateRef State,
}
}
// TODO: Dump destroyed mutex symbols?
DestroyRetValTy DRV = State->get<DestroyRetVal>();
if (!DRV.isEmpty()) {
Out << Sep << "Mutexes in unresolved possibly destroyed state:" << NL;
for (auto I : DRV) {
I.first->dumpToStream(Out);
Out << ": ";
I.second->dumpToStream(Out);
Out << NL;
}
}
}
void PthreadLockChecker::AcquirePthreadLock(const CallEvent &Call,

60
clang/test/Analysis/pthreadlock_state.c Normal file
View file

@ -0,0 +1,60 @@
// RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.unix.PthreadLock,debug.ExprInspection 2>&1 %s | FileCheck %s
#include "Inputs/system-header-simulator-for-pthread-lock.h"
#define NULL 0
void clang_analyzer_printState();
pthread_mutex_t mtx;
void test() {
clang_analyzer_printState();
// CHECK: "checker_messages": null
pthread_mutex_init(&mtx, NULL);
clang_analyzer_printState();
// CHECK: { "checker": "alpha.core.PthreadLockBase", "messages": [
// CHECK-NEXT: "Mutex states:",
// CHECK-NEXT: "mtx: unlocked",
// CHECK-NEXT: ""
// CHECK-NEXT: ]}
pthread_mutex_lock(&mtx);
clang_analyzer_printState();
// CHECK: { "checker": "alpha.core.PthreadLockBase", "messages": [
// CHECK-NEXT: "Mutex states:",
// CHECK-NEXT: "mtx: locked",
// CHECK-NEXT: "Mutex lock order:",
// CHECK-NEXT: "mtx",
// CHECK-NEXT: ""
// CHECK-NEXT: ]}
pthread_mutex_unlock(&mtx);
clang_analyzer_printState();
// CHECK: { "checker": "alpha.core.PthreadLockBase", "messages": [
// CHECK-NEXT: "Mutex states:",
// CHECK-NEXT: "mtx: unlocked",
// CHECK-NEXT: ""
// CHECK-NEXT: ]}
int ret = pthread_mutex_destroy(&mtx);
clang_analyzer_printState();
// CHECK: { "checker": "alpha.core.PthreadLockBase", "messages": [
// CHECK-NEXT: "Mutex states:",
// CHECK-NEXT: "mtx: unlocked, possibly destroyed",
// CHECK-NEXT: "Mutexes in unresolved possibly destroyed state:",
// CHECK-NEXT: "mtx: conj_$
// CHECK-NEXT: ""
// CHECK-NEXT: ]}
if (ret)
return;
clang_analyzer_printState();
// CHECK: { "checker": "alpha.core.PthreadLockBase", "messages": [
// CHECK-NEXT: "Mutex states:",
// CHECK-NEXT: "mtx: destroyed",
// CHECK-NEXT: ""
// CHECK-NEXT: ]}
}

22
clang/test/Analysis/pthreadlock_state_nottracked.c Normal file
View file

@ -0,0 +1,22 @@
// RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.unix.PthreadLock,debug.ExprInspection 2>&1 %s | FileCheck %s
#include "Inputs/system-header-simulator-for-pthread-lock.h"
#define NULL 0
void clang_analyzer_printState();
void test(pthread_mutex_t *mtx) {
int ret = pthread_mutex_destroy(mtx);
clang_analyzer_printState();
// CHECK: { "checker": "alpha.core.PthreadLockBase", "messages": [
// CHECK-NEXT: "Mutex states:",
// CHECK-NEXT: "SymRegion{reg_$[[REG:[0-9]+]]<pthread_mutex_t * mtx>}: not tracked, possibly destroyed",
// CHECK-NEXT: "Mutexes in unresolved possibly destroyed state:",
// CHECK-NEXT: "SymRegion{reg_$[[REG]]<pthread_mutex_t * mtx>}: conj_$
// CHECK-NEXT: ""
// CHECK-NEXT: ]}
if (ret)
return;
pthread_mutex_init(mtx, NULL);
}