squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

Revert GCC -Wnon-virtual-dtor workarounds "[SCEV] Fix GCC -Wnon-virtual-dtor" & "[SampleFDO] Fix -Wnon-virtual-dtor"

Browse source 
This reverts commits 4852c770fe and 6df09d6ccb.

After D109404, -Wnon-virtual-dtor will not be added when the host compiler is GCC.
This commit is contained in:
Fangrui Song 2021-09-08 00:00:33 -07:00
parent 813235947d
commit ca867ef47b
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
llvm/include/llvm/Analysis/ScalarEvolution.h
View file

@ -209,8 +209,7 @@ public:
protected:
SCEVPredicateKind Kind;
// Use virtual to suppress -Wnon-virtual-dtor in the presence of friend.
virtual ~SCEVPredicate() = default;
~SCEVPredicate() = default;
SCEVPredicate(const SCEVPredicate &) = default;
SCEVPredicate &operator=(const SCEVPredicate &) = default;

2
llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h
View file

@ -114,7 +114,7 @@ public:
DenseMap<const BasicBlockT *, SmallVector<const BasicBlockT *, 8>>;
protected:
virtual ~SampleProfileLoaderBaseImpl() = default;
~SampleProfileLoaderBaseImpl() = default;
friend class SampleCoverageTracker;
Function &getFunction(FunctionT &F) {