squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

Make helpers static. NFC.

Browse source
This commit is contained in:
Benjamin Kramer 2020-08-19 15:59:39 +02:00
parent 3d76a133c7
commit b98e25b6d7
5 changed files with 21 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
clang/lib/Tooling/Transformer/RewriteRule.cpp
View file

@ -242,7 +242,7 @@ public:
} // namespace
template <typename T>
llvm::Expected<SmallVector<clang::transformer::Edit, 1>>
static llvm::Expected<SmallVector<clang::transformer::Edit, 1>>
rewriteDescendantsImpl(const T &Node, RewriteRule Rule,
const MatchResult &Result) {
ApplyRuleCallback Callback(std::move(Rule));

6
llvm/lib/ObjectYAML/DWARFEmitter.cpp
View file

@ -800,9 +800,9 @@ static Expected<uint64_t> writeListEntry(raw_ostream &OS,
}
template <typename EntryType>
Error writeDWARFLists(raw_ostream &OS,
ArrayRef<DWARFYAML::ListTable<EntryType>> Tables,
bool IsLittleEndian, bool Is64BitAddrSize) {
static Error writeDWARFLists(raw_ostream &OS,
ArrayRef<DWARFYAML::ListTable<EntryType>> Tables,
bool IsLittleEndian, bool Is64BitAddrSize) {
for (const DWARFYAML::ListTable<EntryType> &Table : Tables) {
// sizeof(version) + sizeof(address_size) + sizeof(segment_selector_size) +
// sizeof(offset_entry_count) = 8

2
llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
View file

@ -3719,7 +3719,7 @@ Value *InstCombinerImpl::foldUnsignedMultiplicationOverflowCheck(ICmpInst &I) {
return Res;
}
Instruction *foldICmpXNegX(ICmpInst &I) {
static Instruction *foldICmpXNegX(ICmpInst &I) {
CmpInst::Predicate Pred;
Value *X;
if (!match(&I, m_c_ICmp(Pred, m_NSWNeg(m_Value(X)), m_Deferred(X))))

22
mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
View file

@ -136,8 +136,8 @@ LogicalResult getMemRefAlignment(LLVMTypeConverter &typeConverter, T op,
}
// Helper that returns the base address of a memref.
LogicalResult getBase(ConversionPatternRewriter &rewriter, Location loc,
Value memref, MemRefType memRefType, Value &base) {
static LogicalResult getBase(ConversionPatternRewriter &rewriter, Location loc,
Value memref, MemRefType memRefType, Value &base) {
// Inspect stride and offset structure.
//
// TODO: flat memory only for now, generalize
@ -153,8 +153,9 @@ LogicalResult getBase(ConversionPatternRewriter &rewriter, Location loc,
}
// Helper that returns a pointer given a memref base.
LogicalResult getBasePtr(ConversionPatternRewriter &rewriter, Location loc,
Value memref, MemRefType memRefType, Value &ptr) {
static LogicalResult getBasePtr(ConversionPatternRewriter &rewriter,
Location loc, Value memref,
MemRefType memRefType, Value &ptr) {
Value base;
if (failed(getBase(rewriter, loc, memref, memRefType, base)))
return failure();
@ -164,9 +165,9 @@ LogicalResult getBasePtr(ConversionPatternRewriter &rewriter, Location loc,
}
// Helper that returns a bit-casted pointer given a memref base.
LogicalResult getBasePtr(ConversionPatternRewriter &rewriter, Location loc,
Value memref, MemRefType memRefType, Type type,
Value &ptr) {
static LogicalResult getBasePtr(ConversionPatternRewriter &rewriter,
Location loc, Value memref,
MemRefType memRefType, Type type, Value &ptr) {
Value base;
if (failed(getBase(rewriter, loc, memref, memRefType, base)))
return failure();
@ -178,9 +179,10 @@ LogicalResult getBasePtr(ConversionPatternRewriter &rewriter, Location loc,
// Helper that returns vector of pointers given a memref base and an index
// vector.
LogicalResult getIndexedPtrs(ConversionPatternRewriter &rewriter, Location loc,
Value memref, Value indices, MemRefType memRefType,
VectorType vType, Type iType, Value &ptrs) {
static LogicalResult getIndexedPtrs(ConversionPatternRewriter &rewriter,
Location loc, Value memref, Value indices,
MemRefType memRefType, VectorType vType,
Type iType, Value &ptrs) {
Value base;
if (failed(getBase(rewriter, loc, memref, memRefType, base)))
return failure();

4
mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
View file

@ -735,6 +735,7 @@ static LogicalResult verify(TensorReshapeOp op) {
return success();
}
namespace {
/// Reshape of a splat constant can be replaced with a constant of the result
/// type.
struct FoldReshapeWithConstant : OpRewritePattern<TensorReshapeOp> {
@ -752,6 +753,7 @@ struct FoldReshapeWithConstant : OpRewritePattern<TensorReshapeOp> {
return success();
}
};
} // namespace
void TensorReshapeOp::getCanonicalizationPatterns(
OwningRewritePatternList &results, MLIRContext *context) {
@ -1288,6 +1290,7 @@ static LogicalResult verifyNamedStructuredOp(NamedStructuredOpType op) {
return verifyGenericOp<NamedStructuredOpType>(op);
}
namespace {
struct EraseDeadLinalgOp : public RewritePattern {
EraseDeadLinalgOp(PatternBenefit benefit = 1)
: RewritePattern(benefit, MatchAnyOpTypeTag()) {}
@ -1312,6 +1315,7 @@ struct EraseDeadLinalgOp : public RewritePattern {
return failure();
}
};
} // namespace
#define CANONICALIZERS_AND_FOLDERS(XXX) \
void XXX::getCanonicalizationPatterns(OwningRewritePatternList &results, \