[BitcodeReader] Check if we can create a null constant for type.
We cannot create null constants for certain types, e.g. VoidTy, FunctionTy or LabelTy. getNullValue asserts if we pass in an unsupported type. We should also check for opaque types, but I'm not sure how. This fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=14795. Reviewers: t.p.northover, jfb, vsk Reviewed By: vsk Tags: #llvm Differential Revision: https://reviews.llvm.org/D65897 llvm-svn: 369557
This commit is contained in:
parent
e4876c9d71
commit
969b3e6a8f
|
@ -2377,6 +2377,8 @@ Error BitcodeReader::parseConstants() {
|
|||
CurTy = flattenPointerTypes(CurFullTy);
|
||||
continue; // Skip the ValueList manipulation.
|
||||
case bitc::CST_CODE_NULL: // NULL
|
||||
if (CurTy->isVoidTy() || CurTy->isFunctionTy() || CurTy->isLabelTy())
|
||||
return error("Invalid type for a constant null value");
|
||||
V = Constant::getNullValue(CurTy);
|
||||
break;
|
||||
case bitc::CST_CODE_INTEGER: // INTEGER: [intval]
|
||||
|
|
6
llvm/test/Bitcode/invalid-type-for-null-constant.ll
Normal file
6
llvm/test/Bitcode/invalid-type-for-null-constant.ll
Normal file
|
@ -0,0 +1,6 @@
|
|||
; Bitcode with a CST_CODE_NULL with void type.
|
||||
|
||||
; RUN: not llvm-dis %s.bc -o - 2>&1 | FileCheck %s
|
||||
|
||||
; CHECK: error: Invalid type for a constant null value
|
||||
|
BIN
llvm/test/Bitcode/invalid-type-for-null-constant.ll.bc
Normal file
BIN
llvm/test/Bitcode/invalid-type-for-null-constant.ll.bc
Normal file
Binary file not shown.
Loading…
Reference in a new issue