From 8928c6dbbf7d1de32e84f3ec2b778c006fc70091 Mon Sep 17 00:00:00 2001 From: Matthias Kramm Date: Thu, 20 Feb 2020 11:08:59 -0800 Subject: [PATCH] Fix some typos in the MLIR documentation. Summary: Fix minor typos in the tutorial and the "writing a pass" page. Differential Revision: https://reviews.llvm.org/D74905 --- mlir/docs/Tutorials/Toy/Ch-4.md | 2 +- mlir/docs/Tutorials/Toy/Ch-5.md | 2 +- mlir/docs/Tutorials/Toy/Ch-6.md | 2 +- mlir/docs/WritingAPass.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mlir/docs/Tutorials/Toy/Ch-4.md b/mlir/docs/Tutorials/Toy/Ch-4.md index d449fe5c7127..b2882991ecdf 100644 --- a/mlir/docs/Tutorials/Toy/Ch-4.md +++ b/mlir/docs/Tutorials/Toy/Ch-4.md @@ -315,7 +315,7 @@ void MulOp::inferShapes() { getResult().setType(getOperand(0).getType()); } At this point, each of the necessary Toy operations provide a mechanism by which to infer their output shapes. The ShapeInferencePass is a FunctionPass: it will -runs on each Function in isolation. MLIR also supports general +run on each Function in isolation. MLIR also supports general [OperationPasses](../../WritingAPass.md#operation-pass) that run on any isolated operation (i.e. other function-like operations), but here our module only contains functions, so there is no need to generalize to all operations. diff --git a/mlir/docs/Tutorials/Toy/Ch-5.md b/mlir/docs/Tutorials/Toy/Ch-5.md index 9dd4bdaf3184..11ed9561d2c6 100644 --- a/mlir/docs/Tutorials/Toy/Ch-5.md +++ b/mlir/docs/Tutorials/Toy/Ch-5.md @@ -39,7 +39,7 @@ framework, we need to provide two things (and an optional third): * A set of [Rewrite Patterns](../../DialectConversion.md#rewrite-pattern-specification) - - These are the set of [patterns](../../QuickstartRewrites.md) used to + - This is the set of [patterns](../../QuickstartRewrites.md) used to convert `illegal` operations into a set of zero or more `legal` ones. * Optionally, a [Type Converter](../../DialectConversion.md#type-conversion). diff --git a/mlir/docs/Tutorials/Toy/Ch-6.md b/mlir/docs/Tutorials/Toy/Ch-6.md index 34b76008f163..e564fcce257a 100644 --- a/mlir/docs/Tutorials/Toy/Ch-6.md +++ b/mlir/docs/Tutorials/Toy/Ch-6.md @@ -275,7 +275,7 @@ int dumpLLVMIR(mlir::ModuleOp module) { Setting up a JIT to run the module containing the LLVM dialect can be done using the `mlir::ExecutionEngine` infrastructure. This is a utility wrapper around LLVM's JIT that accepts `.mlir` as input. The full code listing for setting up -the JIT can be found in `Ch6/toy.cpp` in the `runJit()` function: +the JIT can be found in `Ch6/toyc.cpp` in the `runJit()` function: ```c++ int runJit(mlir::ModuleOp module) { diff --git a/mlir/docs/WritingAPass.md b/mlir/docs/WritingAPass.md index 5119c469e208..40a998156bd1 100644 --- a/mlir/docs/WritingAPass.md +++ b/mlir/docs/WritingAPass.md @@ -127,7 +127,7 @@ invalidated) based upon other properties such as analyses sets. ### Querying Analyses -The base `OperationPass` class provide utilities for querying and preserving +The base `OperationPass` class provides utilities for querying and preserving analyses for the current operation being processed. * OperationPass automatically provides the following utilities for querying