squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

[flang] Ensure a characterized ENTRY in a PURE subprogram is also marked PURE

Browse source 
ENTRY point symbols aren't marked PURE in the symbol table, but must
instead inherit the attribute from their containing subprograms.
There's a predicate in semantics that does this, but it wasn't being
used in the context of actual procedure argument characterization.

Differential Revision: https://reviews.llvm.org/D119564
This commit is contained in:
Peter Klausler 2022-02-08 10:07:55 -08:00
parent 8de457eafc
commit 882d5f14ad
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
flang/lib/Evaluate/characteristics.cpp
View file

@ -371,13 +371,13 @@ static std::optional<Procedure> CharacterizeProcedure(
seenProcs.insert(symbol);
CopyAttrs<Procedure, Procedure::Attr>(symbol, result,
{
{semantics::Attr::PURE, Procedure::Attr::Pure},
{semantics::Attr::ELEMENTAL, Procedure::Attr::Elemental},
{semantics::Attr::BIND_C, Procedure::Attr::BindC},
});
if (result.attrs.test(Procedure::Attr::Elemental) &&
!symbol.attrs().test(semantics::Attr::IMPURE)) {
result.attrs.set(Procedure::Attr::Pure); // explicitly flag pure procedures
if (IsPureProcedure(symbol) || // works for ENTRY too
(!symbol.attrs().test(semantics::Attr::IMPURE) &&
result.attrs.test(Procedure::Attr::Elemental))) {
result.attrs.set(Procedure::Attr::Pure);
}
return std::visit(
common::visitors{
@ -809,8 +809,8 @@ std::optional<Procedure> Procedure::Characterize(
std::optional<Procedure> Procedure::Characterize(
const ProcedureDesignator &proc, FoldingContext &context) {
if (const auto *symbol{proc.GetSymbol()}) {
if (auto result{characteristics::Procedure::Characterize(
ResolveAssociations(*symbol), context)}) {
if (auto result{
characteristics::Procedure::Characterize(*symbol, context)}) {
return result;
}
} else if (const auto *intrinsic{proc.GetSpecificIntrinsic()}) {