[clang-tidy] Simplify throw keyword missing check

Extend test to verify that it does not match in template instantiations.

Differential Revision: https://reviews.llvm.org/D96132

clang-tools-extra/clang-tidy/bugprone/ThrowKeywordMissingCheck.cpp

@@ -21,8 +21,7 @@ void ThrowKeywordMissingCheck::registerMatchers(MatchFinder *Finder) {
       cxxConstructorDecl(hasAnyConstructorInitializer(anything()));
 
   Finder->addMatcher(
-      expr(anyOf(cxxFunctionalCastExpr(), cxxBindTemporaryExpr(),
-                 cxxTemporaryObjectExpr()),
+      cxxConstructExpr(
           hasType(cxxRecordDecl(
               isSameOrDerivedFrom(matchesName("[Ee]xception|EXCEPTION")))),
           unless(anyOf(hasAncestor(stmt(

clang-tools-extra/clang-tidy/bugprone/ThrowKeywordMissingCheck.h

@@ -29,6 +29,9 @@ public:
   }
   void registerMatchers(ast_matchers::MatchFinder *Finder) override;
   void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
+  llvm::Optional<TraversalKind> getCheckTraversalKind() const override {
+    return TK_IgnoreUnlessSpelledInSource;
+  }
 };
 
 } // namespace bugprone

clang-tools-extra/test/clang-tidy/checkers/bugprone-throw-keyword-missing.cpp

@@ -94,8 +94,17 @@ void nameContainsExceptionThrownTest(int i) {
 template <class Exception>
 void f(int i, Exception excToBeThrown) {}
 
+template <class SomeType>
+void templ(int i) {
+  if (i > 0)
+    SomeType();
+}
+
 void funcCallWithTempExcTest() {
   f(5, RegularException());
+
+  templ<RegularException>(4);
+  templ<RegularClass>(4);
 }
 
 // Global variable initialization test.