squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

[Analysis] improve function signature checking for calloc

Browse source 
This would crash later if we thought the parameters were
valid for the standard library call as shown in:
https://llvm.org/PR50846
This commit is contained in:
Sanjay Patel 2021-06-25 13:19:39 -04:00
parent f45eee2706
commit 7414bbebc2
2 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
llvm/lib/Analysis/TargetLibraryInfo.cpp
View file

@ -996,7 +996,8 @@ bool TargetLibraryInfoImpl::isValidProtoForLibFunc(const FunctionType &FTy,
return (NumParams == 2 && FTy.getParamType(0)->isPointerTy());
case LibFunc_calloc:
case LibFunc_vec_calloc:
return (NumParams == 2 && FTy.getReturnType()->isPointerTy());
return (NumParams == 2 && FTy.getReturnType()->isPointerTy() &&
FTy.getParamType(0) == FTy.getParamType(1));
case LibFunc_atof:
case LibFunc_atoi:

16
llvm/test/Transforms/InstCombine/calloc-mismatch.ll Normal file
View file

@ -0,0 +1,16 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -instcombine -S | FileCheck %s
; The argument types should match if it is the standard library calloc.
; Don't crash analyzing an imposter.
declare i8* @calloc(i64, i32)
define void @PR50846() {
; CHECK-LABEL: @PR50846(
; CHECK-NEXT: [[CALL:%.*]] = call i8* @calloc(i64 1, i32 1)
; CHECK-NEXT: ret void
;
%call = call i8* @calloc(i64 1, i32 1)
ret void
}