squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

SymbolManager::SymbolDependencies: Use unique_ptr to simplify memory management

Browse source
This commit is contained in:
David Blaikie 2020-04-28 21:03:57 -07:00
parent e265f92b6e
commit 628829254d
2 changed files with 6 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h
View file

@ -459,7 +459,8 @@ public:
class SymbolManager {
using DataSetTy = llvm::FoldingSet<SymExpr>;
using SymbolDependTy = llvm::DenseMap<SymbolRef, SymbolRefSmallVectorTy *>;
using SymbolDependTy =
llvm::DenseMap<SymbolRef, std::unique_ptr<SymbolRefSmallVectorTy>>;
DataSetTy DataSet;
@ -476,7 +477,6 @@ public:
SymbolManager(ASTContext &ctx, BasicValueFactory &bv,
llvm::BumpPtrAllocator& bpalloc)
: SymbolDependencies(16), BPAlloc(bpalloc), BV(bv), Ctx(ctx) {}
~SymbolManager();
static bool canSymbolicate(QualType T);

16
clang/lib/StaticAnalyzer/Core/SymbolManager.cpp
View file

@ -341,10 +341,6 @@ QualType SymbolRegionValue::getType() const {
return R->getValueType();
}
SymbolManager::~SymbolManager() {
llvm::DeleteContainerSeconds(SymbolDependencies);
}
bool SymbolManager::canSymbolicate(QualType T) {
T = T.getCanonicalType();
@ -362,13 +358,9 @@ bool SymbolManager::canSymbolicate(QualType T) {
void SymbolManager::addSymbolDependency(const SymbolRef Primary,
const SymbolRef Dependent) {
SymbolDependTy::iterator I = SymbolDependencies.find(Primary);
SymbolRefSmallVectorTy *dependencies = nullptr;
if (I == SymbolDependencies.end()) {
dependencies = new SymbolRefSmallVectorTy();
SymbolDependencies[Primary] = dependencies;
} else {
dependencies = I->second;
auto &dependencies = SymbolDependencies[Primary];
if (!dependencies) {
dependencies = std::make_unique<SymbolRefSmallVectorTy>();
}
dependencies->push_back(Dependent);
}
@ -378,7 +370,7 @@ const SymbolRefSmallVectorTy *SymbolManager::getDependentSymbols(
SymbolDependTy::const_iterator I = SymbolDependencies.find(Primary);
if (I == SymbolDependencies.end())
return nullptr;
return I->second;
return I->second.get();
}
void SymbolReaper::markDependentsLive(SymbolRef sym) {