squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

[PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only.

Browse source 
The `__builtin_pdepd` and `__builtin_pextd` are P10 builtins that are meant to
be used under 64-bit only. For instance, when the builtins are compiled under
32-bit mode:
```
$ cat t.c
unsigned long long foo(unsigned long long a, unsigned long long b) {
  return __builtin_pextd(a,b);
}

$ clang -c t.c -mcpu=pwr10 -m32
ExpandIntegerResult #0: t31: i64 = llvm.ppc.pextd TargetConstant:i32<6928>, t28, t29

fatal error: error in backend: Do not know how to expand the result of this operator!
```
This patch adds sema checking for these builtins to compile under 64-bit
mode only and on P10. The builtins will emit a diagnostic when they are compiled on
non-P10 compilations and on 32-bit mode.

Differential Revision: https://reviews.llvm.org/D118753
This commit is contained in:
Amy Kwan 2022-02-15 10:47:55 -06:00
parent 6bd72fa661
commit 5dc0a1657b
3 changed files with 43 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
clang/lib/Sema/SemaChecking.cpp
View file

@ -3604,6 +3604,8 @@ static bool isPPC_64Builtin(unsigned BuiltinID) {
case PPC::BI__builtin_divde:
case PPC::BI__builtin_divdeu:
case PPC::BI__builtin_bpermd:
case PPC::BI__builtin_pdepd:
case PPC::BI__builtin_pextd:
case PPC::BI__builtin_ppc_ldarx:
case PPC::BI__builtin_ppc_stdcx:
case PPC::BI__builtin_ppc_tdw:
@ -3763,6 +3765,10 @@ bool Sema::CheckPPCBuiltinFunctionCall(const TargetInfo &TI, unsigned BuiltinID,
case PPC::BI__builtin_pack_vector_int128:
return SemaFeatureCheck(*this, TheCall, "vsx",
diag::err_ppc_builtin_only_on_arch, "7");
case PPC::BI__builtin_pdepd:
case PPC::BI__builtin_pextd:
return SemaFeatureCheck(*this, TheCall, "isa-v31-instructions",
diag::err_ppc_builtin_only_on_arch, "10");
case PPC::BI__builtin_altivec_vgnb:
return SemaBuiltinConstantArgRange(TheCall, 1, 2, 7);
case PPC::BI__builtin_altivec_vec_replace_elt:

34
clang/test/CodeGen/PowerPC/builtins-ppc-pwr10-64bit.c Normal file
View file

@ -0,0 +1,34 @@
// REQUIRES: powerpc-registered-target
// RUN: %clang_cc1 -triple powerpc64-unknown-linux-gnu -emit-llvm %s \
// RUN: -target-cpu pwr10 -o - | FileCheck %s
// RUN: %clang_cc1 -triple powerpc64le-unknown-linux-gnu -emit-llvm %s \
// RUN: -target-cpu pwr10 -o - | FileCheck %s
// RUN: %clang_cc1 -triple powerpc64-unknown-aix -emit-llvm %s \
// RUN: -target-cpu pwr10 -o - | FileCheck %s
// RUN: not %clang_cc1 -triple powerpc-unknown-aix -emit-llvm-only %s \
// RUN: -target-cpu pwr8 2>&1 | FileCheck %s --check-prefix=CHECK-32-ERROR
// RUN: not %clang_cc1 -triple powerpc-unknown-linux-gnu -emit-llvm-only %s \
// RUN: -target-cpu pwr9 2>&1 | FileCheck %s --check-prefix=CHECK-32-ERROR
// RUN: not %clang_cc1 -triple powerpc64-unknown-aix -emit-llvm-only %s \
// RUN: -target-cpu pwr9 2>&1 | FileCheck %s --check-prefix=CHECK-NONPWR10-ERR
// RUN: not %clang_cc1 -triple powerpc64-unknown-linux-gnu -emit-llvm-only %s \
// RUN: -target-cpu pwr8 2>&1 | FileCheck %s --check-prefix=CHECK-NONPWR10-ERR
extern unsigned long long ull;
unsigned long long test_builtin_pextd() {
// CHECK-LABEL: @test_builtin_pextd(
// CHECK: %2 = call i64 @llvm.ppc.pextd(i64 %0, i64 %1)
// CHECK-32-ERROR: error: this builtin is only available on 64-bit targets
// CHECK-NONPWR10-ERR: error: this builtin is only valid on POWER10 or later CPUs
return __builtin_pextd(ull, ull);
}
unsigned long long test_builtin_pdepd() {
// CHECK-LABEL: @test_builtin_pdepd(
// CHECK: %2 = call i64 @llvm.ppc.pdepd(i64 %0, i64 %1)
// CHECK-32-ERROR: error: this builtin is only available on 64-bit targets
// CHECK-NONPWR10-ERR: error: this builtin is only valid on POWER10 or later CPUs
return __builtin_pdepd(ull, ull);
}

3
llvm/test/CodeGen/PowerPC/p10-bit-manip-ops.ll
View file

@ -2,6 +2,9 @@
; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
; RUN: -mcpu=pwr10 -ppc-asm-full-reg-names -ppc-vsr-nums-as-vr < %s | \
; RUN: FileCheck %s
; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-aix \
; RUN: -mcpu=pwr10 -ppc-asm-full-reg-names -ppc-vsr-nums-as-vr < %s | \
; RUN: FileCheck %s
; These test cases aim to test the bit manipulation operations on Power10.