squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

[mlir]: Clarify docs for external OpTrait::FunctionLike ops

Browse source 
The documentation claims that an op with the trait FunctionLike has a
single region containing the blocks that corresponding to the body of
the function. It then goes on to say that the absence of a region
corresponds to an external function when, in fact, this is represented
by a single empty region. This patch changes the wording in the
documentation to match the implementation.

Signed-off-by: Frej Drejhammar <frej.drejhammar@gmail.com>
Co-authored-by: Frej Drejhammar <frej.drejhammar@gmail.com>
Co-authored-by: Klas Segeljakt <klasseg@kth.se>

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D89868
This commit is contained in:
Frej Drejhammar 2020-10-21 18:07:30 +02:00 committed by Alex Zinenko
parent 1ed4caff1d
commit 4b7dafd904
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
mlir/docs/Traits.md
View file

@ -249,7 +249,7 @@ particular:
- Ops must be symbols, i.e. also have the `Symbol` trait;
- Ops have a single region with multiple blocks that corresponds to the body
of the function;
- the absence of a region corresponds to an external function;
- An op with a single empty region corresponds to an external function;
- arguments of the first block of the region are treated as function
arguments;
- they can have argument and result attributes that are stored in dictionary

2
mlir/include/mlir/IR/FunctionSupport.h
View file

@ -79,7 +79,7 @@ namespace OpTrait {
/// - Ops must be symbols, i.e. also have the `Symbol` trait;
/// - Ops have a single region with multiple blocks that corresponds to the body
/// of the function;
/// - the absence of a region corresponds to an external function;
/// - An op with a single empty region corresponds to an external function;
/// - leading arguments of the first block of the region are treated as function
/// arguments;
/// - they can have argument attributes that are stored in a dictionary