squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

Revert "Adding GDB PrettyPrinter for mlir::Identifier."

Browse source 
This reverts commit 9e9e6e698d.

This commit is causing builds that include the 'debuginfo-tests' project to
fail.

Apple has a public bot which shows the failure:
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/23667/console
This commit is contained in:
OCHyams 2020-09-03 08:28:15 +01:00
parent f9091e56d3
commit 485e6db872
6 changed files with 0 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
debuginfo-tests/CMakeLists.txt
View file

@ -9,12 +9,6 @@ add_llvm_executable(check-gdb-llvm-support
)
target_link_libraries(check-gdb-llvm-support PRIVATE LLVMSupport)
add_llvm_executable(check-gdb-mlir-support
llvm-prettyprinters/gdb/mlir-support.cpp
)
target_include_directories(check-gdb-mlir-support PRIVATE ${LLVM_EXTERNAL_MLIR_SOURCE_DIR}/include)
target_link_libraries(check-gdb-mlir-support PRIVATE MLIRIR)
set(DEBUGINFO_TESTS_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
set(DEBUGINFO_TESTS_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
@ -25,7 +19,6 @@ set(DEBUGINFO_TEST_DEPS
llvm-config
llvm-objdump
check-gdb-llvm-support
check-gdb-mlir-support
not
)

1
debuginfo-tests/lit.cfg.py
View file

@ -46,7 +46,6 @@ tools = [
config.debuginfo_tests_src_root, 'llgdb-tests', 'test_debuginfo.pl')),
ToolSubst("%llvm_src_root", config.llvm_src_root),
ToolSubst("%llvm_tools_dir", config.llvm_tools_dir),
ToolSubst("%mlir_src_root", config.mlir_src_root),
]
def get_required_attr(config, attr_name):

2
debuginfo-tests/lit.site.cfg.py.in
View file

@ -20,8 +20,6 @@ config.target_triple = "@TARGET_TRIPLE@"
config.host_arch = "@HOST_ARCH@"
config.is_msvc = lit.util.pythonize_bool("@MSVC@")
config.mlir_src_root = "@MLIR_SOURCE_DIR@"
config.llvm_use_sanitizer = "@LLVM_USE_SANITIZER@"
config.python3_executable = "@Python3_EXECUTABLE@"

8
debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.cpp
View file

@ -1,8 +0,0 @@
#include "mlir/IR/Identifier.h"
#include "mlir/IR/MLIRContext.h"
mlir::MLIRContext Context;
auto Identifier = mlir::Identifier::get("foo", &Context);
int main() { return 0; }

8
debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.gdb
View file

@ -1,8 +0,0 @@
# RUN: gdb -q -batch -n -iex 'source %mlir_src_root/utils/gdb-scripts/prettyprinters.py' -x %s %llvm_tools_dir/check-gdb-mlir-support | FileCheck %s --dump-input=fail
# REQUIRES: debug-info
break main
run
# CHECK: "foo"
p Identifier

22
mlir/utils/gdb-scripts/prettyprinters.py
View file

@ -1,22 +0,0 @@
"""GDB pretty printers for MLIR types."""
import gdb.printing
class IdentifierPrinter:
"""Prints an mlir::Identifier instance."""
def __init__(self, val):
self.entry = val['entry']
def to_string(self):
ptr = (self.entry + 1).cast(gdb.lookup_type('char').pointer());
return ptr.string(length=self.entry['keyLength'])
def display_hint(self):
return 'string'
pp = gdb.printing.RegexpCollectionPrettyPrinter('MLIRSupport')
pp.add_printer('mlir::Identifier', '^mlir::Identifier$', IdentifierPrinter)
gdb.printing.register_pretty_printer(gdb.current_objfile(), pp)