squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

Fix "Cannot update ranges for DIE at offset" error messages.

Browse source 
Summary:
Fix the error message by not printing it :)

Explanation: a previous diff accidentally removed this error message from within
the DEBUG macro, and it's expected that we'll have a bunch of them since a lot
of the DIEs we try to update are empty or meaningless. For instance (and mainly), there
is a huge number of lexical block DIEs with no attributes in .debug_info.
In the first phase of collecting debugging info, we store the offsets of all
these DIEs, only later to realize that we cannot update their address
ranges because they have none.

A better fix would be to check this earlier and not store offsets of DIEs
we cannot update to begin with.

(cherry picked from FBD3236923)
This commit is contained in:
Gabriel Poesia 2016-04-28 12:55:35 -07:00 committed by Maksim Panchenko
parent de95a5b6a4
commit 459eb8c230
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
bolt/RewriteInstance.cpp
View file

@ -2367,8 +2367,8 @@ void RewriteInstance::updateDWARFObjectAddressRanges(
DebugInfoPatcher->addBinaryPatch(LowPCOffset + 4, ProducerString);
} else {
errs() << "BOLT-WARNING: Cannot update ranges for DIE at offset 0x"
<< Twine::utohexstr(DIE->getOffset()) << "\n";
DEBUG(errs() << "BOLT-WARNING: Cannot update ranges for DIE at offset 0x"
<< Twine::utohexstr(DIE->getOffset()) << "\n");
}
}
}