squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

[analyzer] Fixing SVal::getType returns Null Type for NonLoc::ConcreteInt in boolean type

Browse source 
In method `TypeRetrievingVisitor::VisitConcreteInt`, `ASTContext::getIntTypeForBitwidth` is used to get the type for `ConcreteInt`s.
However, the getter in ASTContext cannot handle the boolean type with the bit width of 1, which will make method `SVal::getType` return a Null `Type`.
In this patch, a check for this case is added to fix this problem by returning the bool type directly when the bit width is 1.

Differential Revision: https://reviews.llvm.org/D129737
This commit is contained in:
Ella Ma 2022-07-14 15:54:40 +08:00
parent 74902cc96f
commit 32fe1a4be9
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
clang/lib/StaticAnalyzer/Core/SVals.cpp
View file

@ -136,6 +136,8 @@ public:
}
template <class ConcreteInt> QualType VisitConcreteInt(ConcreteInt CI) {
const llvm::APSInt &Value = CI.getValue();
if (1 == Value.getBitWidth())
return Context.BoolTy;
return Context.getIntTypeForBitwidth(Value.getBitWidth(), Value.isSigned());
}
QualType VisitLocConcreteInt(loc::ConcreteInt CI) {

5
clang/unittests/StaticAnalyzer/SValTest.cpp
View file

@ -161,6 +161,7 @@ SVAL_TEST(GetConstType, R"(
void foo() {
int x = 42;
int *y = nullptr;
bool z = true;
})") {
SVal X = getByName("x");
ASSERT_FALSE(X.getType(Context).isNull());
@ -170,6 +171,10 @@ void foo() {
ASSERT_FALSE(Y.getType(Context).isNull());
expectSameSignAndBitWidth(Context.getUIntPtrType(), Y.getType(Context),
Context);
SVal Z = getByName("z");
ASSERT_FALSE(Z.getType(Context).isNull());
EXPECT_EQ(Context.BoolTy, Z.getType(Context));
}
SVAL_TEST(GetLocAsIntType, R"(