squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

[clang][sema] - remove CodeCompleter nullptr checks

Browse source 
All paths have already dereferenced the CodeCompleter pointer in the ResultBuilder constructor
This commit is contained in:
Simon Pilgrim 2022-02-11 15:09:32 +00:00
parent 5fb180704c
commit 1e64590041
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
clang/lib/Sema/SemaCodeComplete.cpp
View file

@ -9787,7 +9787,7 @@ void Sema::CodeCompletePreprocessorMacroName(bool IsDefinition) {
CodeCompleter->getCodeCompletionTUInfo(),
IsDefinition ? CodeCompletionContext::CCC_MacroName
: CodeCompletionContext::CCC_MacroNameUse);
if (!IsDefinition && (!CodeCompleter || CodeCompleter->includeMacros())) {
if (!IsDefinition && CodeCompleter->includeMacros()) {
// Add just the names of macros, not their arguments.
CodeCompletionBuilder Builder(Results.getAllocator(),
Results.getCodeCompletionTUInfo());
@ -9814,9 +9814,8 @@ void Sema::CodeCompletePreprocessorExpression() {
CodeCompleter->getCodeCompletionTUInfo(),
CodeCompletionContext::CCC_PreprocessorExpression);
if (!CodeCompleter || CodeCompleter->includeMacros())
AddMacroResults(PP, Results,
!CodeCompleter || CodeCompleter->loadExternal(), true);
if (CodeCompleter->includeMacros())
AddMacroResults(PP, Results, CodeCompleter->loadExternal(), true);
// defined (<macro>)
Results.EnterNewScope();