From e7bcde8ca0d376d9d23d61855baf67122a66c76a Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 12 Apr 2016 10:52:58 -0400 Subject: [PATCH] Remove unnecessary definition of _WIN64 in libpq/win32.mak. In commit b0e40d189325dc7a54d2546245e766f8c47a7c8d, I should have just removed the /D switch defining WIN64. The reason the code worked before is that all Windows64 compilers automatically predefine _WIN64. Perhaps at one time we had code that depended on WIN64 being defined, but it's long gone, and we should not encourage any reappearance. Per discussion with Christian Ullrich. --- src/interfaces/libpq/win32.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/interfaces/libpq/win32.mak b/src/interfaces/libpq/win32.mak index 1d8c84d5a2..88c3657035 100644 --- a/src/interfaces/libpq/win32.mak +++ b/src/interfaces/libpq/win32.mak @@ -16,7 +16,7 @@ CPU=i386 !MESSAGE Building the Win32 static library... !MESSAGE !ELSEIF ("$(CPU)" == "IA64")||("$(CPU)" == "AMD64") -ADD_DEFINES=/D "_WIN64" /Wp64 /GS +ADD_DEFINES=/Wp64 /GS ADD_SECLIB=bufferoverflowU.lib !MESSAGE Building the Win64 static library... !MESSAGE